Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2267403003: GN build rules for four audio processing test executables (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1, aleloi, ivoc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN build rules for four audio processing test executables click_annotate, intelligibility_proc, nonlinear_beamformer_test, and transient_suppression_test. BUG=webrtc:5949 Committed: https://crrev.com/538b5606a3fb6310aab7a7e747aee16eac885f02 Cr-Commit-Position: refs/heads/master@{#13890}

Patch Set 1 #

Patch Set 2 : fix? #

Total comments: 5

Patch Set 3 : use default dependency names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 2 2 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kwiberg-webrtc
4 years, 4 months ago (2016-08-23 12:45:46 UTC) #2
kjellander_webrtc
https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn#newcode445 webrtc/modules/audio_processing/BUILD.gn:445: "//third_party/gflags:gflags", You can skip :gflags here (same below). https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn#newcode449 ...
4 years, 4 months ago (2016-08-23 18:45:16 UTC) #3
kwiberg-webrtc
New patch set uploaded. https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn#newcode445 webrtc/modules/audio_processing/BUILD.gn:445: "//third_party/gflags:gflags", On 2016/08/23 18:45:16, kjellander_webrtc ...
4 years, 4 months ago (2016-08-24 07:41:32 UTC) #4
kjellander_webrtc
lgtm https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/2267403003/diff/20001/webrtc/modules/audio_processing/BUILD.gn#newcode449 webrtc/modules/audio_processing/BUILD.gn:449: configs -= [ "//build/config/clang:find_bad_constructs" ] On 2016/08/24 07:41:32, ...
4 years, 4 months ago (2016-08-24 08:36:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2267403003/40001
4 years, 4 months ago (2016-08-24 08:50:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 11:38:51 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/538b5606a3fb6310aab7a7e747aee16eac885f02 Cr-Commit-Position: refs/heads/master@{#13890}
4 years, 4 months ago (2016-08-24 11:38:59 UTC) #10
sakal
4 years, 4 months ago (2016-08-24 12:04:14 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2274813004/ by sakal@webrtc.org.

The reason for reverting is: Breaks most of chromium.webrtc.fyi bots..

Powered by Google App Engine
This is Rietveld 408576698