Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issue 2273713003: Make dependency of audio_device of ApplicationServices explicit. (Closed)

Created:
4 years, 4 months ago by Max Morin WebRTC
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make dependency of audio_device of ApplicationServices explicit. Tested in https://codereview.webrtc.org/2276903002. BUG=webrtc:6170 NOTRY=true Committed: https://crrev.com/2ec45b9ffa3382844c95e78f135bf2527252db50 Cr-Commit-Position: refs/heads/master@{#13895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Max Morin WebRTC
Kjellander: PTAL.
4 years, 4 months ago (2016-08-24 10:48:26 UTC) #3
kjellander_webrtc
lgtm, thanks! Can you try running GN builds of audio_device_test and voe_auto_test on Mac before ...
4 years, 4 months ago (2016-08-24 11:31:31 UTC) #4
Max Morin WebRTC
On 2016/08/24 11:31:31, kjellander_webrtc wrote: > lgtm, thanks! > Can you try running GN builds ...
4 years, 4 months ago (2016-08-24 11:38:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2273713003/1
4 years, 4 months ago (2016-08-24 13:42:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 13:51:12 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:51:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ec45b9ffa3382844c95e78f135bf2527252db50
Cr-Commit-Position: refs/heads/master@{#13895}

Powered by Google App Engine
This is Rietveld 408576698