Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2276903002: Make dependency of audio_device of ApplicationServices explicit. (Closed)

Created:
4 years, 3 months ago by Max Morin WebRTC
Modified:
4 years, 3 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make dependency of audio_device of ApplicationServices explicit. BUG=6170

Patch Set 1 #

Patch Set 2 : Test with gn bots for real. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -135 lines) Patch
M webrtc/build/mb_config.pyl View 1 4 chunks +123 lines, -135 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (7 generated)
Max Morin WebRTC
The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run
4 years, 3 months ago (2016-08-24 10:30:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2276903002/1
4 years, 3 months ago (2016-08-24 10:30:40 UTC) #2
Max Morin WebRTC
The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run
4 years, 3 months ago (2016-08-24 10:37:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2276903002/20001
4 years, 3 months ago (2016-08-24 10:37:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-08-24 10:40:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/17383)
4 years, 3 months ago (2016-08-24 10:41:00 UTC) #6
Max Morin WebRTC
4 years, 3 months ago (2016-08-24 14:44:34 UTC) #7 
Description was changed from

==========
Make dependency of audio_device of ApplicationServices explicit.

BUG=6170
==========

to

==========
Make dependency of audio_device of ApplicationServices explicit.

BUG=6170
==========

Powered by Google App Engine
This is Rietveld 408576698