Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2272563004: Removed inline definitions and added destructors to fix chromium-style. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 3 months ago
Reviewers:
aleloi2, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@real_master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed inline definitions and added destructors to fix chromium-style. BUG=webrtc:163 Committed: https://crrev.com/5f09980bb5adb04fbc23aea280121c41a64ac02b Cr-Commit-Position: refs/heads/master@{#13911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/modules/audio_processing/audio_processing.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aleloi
I tried to enable the find_bad_constructs for the new audio mixer. After fixing the actual ...
4 years, 4 months ago (2016-08-24 12:58:07 UTC) #2
kwiberg-webrtc
lgtm. I think you picked the right .cc file. Every .h should have a .cc, ...
4 years, 3 months ago (2016-08-24 22:00:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2272563004/1
4 years, 3 months ago (2016-08-25 04:11:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 07:45:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 07:45:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f09980bb5adb04fbc23aea280121c41a64ac02b
Cr-Commit-Position: refs/heads/master@{#13911}

Powered by Google App Engine
This is Rietveld 408576698