Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2272563004: Removed inline definitions and added destructors to fix chromium-style. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@real_master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 06bfc9ba7f9d8531044105ea4ddd3790cbf90a31..09e5d5be1cba9b20a8b8210c690c3c23e1dc7709 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -145,22 +145,13 @@ struct ExperimentalNs {
// Use to enable beamforming. Must be provided through the constructor. It will
// have no impact if used with AudioProcessing::SetExtraOptions().
struct Beamforming {
- Beamforming()
- : enabled(false),
- array_geometry(),
- target_direction(
- SphericalPointf(static_cast<float>(M_PI) / 2.f, 0.f, 1.f)) {}
- Beamforming(bool enabled, const std::vector<Point>& array_geometry)
- : Beamforming(enabled,
- array_geometry,
- SphericalPointf(static_cast<float>(M_PI) / 2.f, 0.f, 1.f)) {
- }
+ Beamforming();
+ Beamforming(bool enabled, const std::vector<Point>& array_geometry);
Beamforming(bool enabled,
const std::vector<Point>& array_geometry,
- SphericalPointf target_direction)
- : enabled(enabled),
- array_geometry(array_geometry),
- target_direction(target_direction) {}
+ SphericalPointf target_direction);
+ ~Beamforming();
+
static const ConfigOptionID identifier = ConfigOptionID::kBeamforming;
const bool enabled;
const std::vector<Point> array_geometry;
@@ -450,9 +441,7 @@ class AudioProcessing {
// Same as above but uses an existing PlatformFile handle. Takes ownership
// of |handle| and closes it at StopDebugRecording().
// TODO(xians): Make this interface pure virtual.
- virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) {
- return -1;
- }
+ virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle);
// Stops recording debugging information, and closes the file. Recording
// cannot be resumed in the same file (without overwriting it).
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698