Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2271583003: Implement CVO for iOS capturer (Closed)

Created:
4 years, 4 months ago by magjed_webrtc
Modified:
4 years, 3 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement CVO for iOS capturer The rotation is currently always applied by AVFoundation by reconfiguring the capture connection video orientation. This CL sets the rotation field in the frame instead. This avoids the current flash in the video when the device is rotated, and also avoids reconfiguring the local encoder and remote decoder when the device is rotated. BUG=b/30651939 Committed: https://crrev.com/2ab012c41e57f21f380aec2c30818d3714fd0f6e Cr-Commit-Position: refs/heads/master@{#13916}

Patch Set 1 : Move GN stuff. #

Total comments: 5

Patch Set 2 : Address tkchin@s comments #

Patch Set 3 : Default to portrait orientation on iPhone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M webrtc/sdk/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 2 12 chunks +52 lines, -32 lines 0 comments Download
M webrtc/sdk/sdk.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
magjed_webrtc
Zeke - please take a look.
4 years, 4 months ago (2016-08-23 14:07:31 UTC) #4
tkchin_webrtc
https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h (right): https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h#newcode59 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h:59: void CaptureSampleBuffer(CMSampleBufferRef sampleBuffer, this wasn't you, but a relic ...
4 years, 4 months ago (2016-08-23 17:33:20 UTC) #5
tkchin_webrtc
https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm#newcode234 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:234: _rotation = webrtc::kVideoRotation_0; On 2016/08/23 17:33:19, tkchin_webrtc wrote: > ...
4 years, 4 months ago (2016-08-23 17:37:25 UTC) #6
magjed_webrtc
https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h (right): https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h#newcode59 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h:59: void CaptureSampleBuffer(CMSampleBufferRef sampleBuffer, On 2016/08/23 17:33:19, tkchin_webrtc wrote: > ...
4 years, 4 months ago (2016-08-24 11:08:36 UTC) #8
tkchin_webrtc
On 2016/08/24 11:08:36, magjed_webrtc wrote: > https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h > File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h (right): > > https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h#newcode59 > ...
4 years, 4 months ago (2016-08-24 17:21:24 UTC) #9
tkchin_webrtc
On 2016/08/24 17:21:24, tkchin_webrtc wrote: > On 2016/08/24 11:08:36, magjed_webrtc wrote: > > > https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h ...
4 years, 4 months ago (2016-08-24 17:28:46 UTC) #10
magjed_webrtc
On 2016/08/24 17:21:24, tkchin_webrtc wrote: > On 2016/08/24 11:08:36, magjed_webrtc wrote: > > > https://codereview.webrtc.org/2271583003/diff/20001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h ...
4 years, 3 months ago (2016-08-25 08:42:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2271583003/80001
4 years, 3 months ago (2016-08-25 09:08:32 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 3 months ago (2016-08-25 10:25:08 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 10:25:20 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ab012c41e57f21f380aec2c30818d3714fd0f6e
Cr-Commit-Position: refs/heads/master@{#13916}

Powered by Google App Engine
This is Rietveld 408576698