Move InsertZeroColumns and CopyColumn to ::internal. (pt. 1)

Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654
Committed: https://crrev.com/00e45bb09d9d5e78b0dd614a1a28bbb98683fb1e
Cr-Commit-Position: refs/heads/master@{#13914}

[brandtr, 2016-08-23 07:54:29]

Description was changed from

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the encoding/decoding operation. The ::internal namespace is used
for packet mask-related functions, and will be renamed later on.

BUG=webrtc:5654
==========

to

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the encoding/decoding operation. The ::internal namespace is used
for packet mask-related functions, and will be renamed later on.

BUG=webrtc:5654
==========

[brandtr, 2016-08-23 08:08:49]

Description was changed from

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the encoding/decoding operation. The ::internal namespace is used
for packet mask-related functions, and will be renamed later on.

BUG=webrtc:5654
==========

to

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is
used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654
==========

[brandtr, 2016-08-23 08:17:52]

brandtr@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[brandtr, 2016-08-23 08:17:53]

Split up previous large CL in five semi-indenpendent ones.

[danilchap, 2016-08-23 08:43:00]

lgtm

https://codereview.webrtc.org/2269893002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/forward_error_correction.cc (right):

https://codereview.webrtc.org/2269893002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/forward_error_correction.cc:320: const uint16_t
num_zeros_to_insert =
probably better to leave this type as int:
variable represent count that is better to type as size_t or as int.
InsertZeroColumns accepts it as int, so int look like better choice.
cast next line is done for proper wrapping, not for proper typing.
Alternatively change it to size_t (like with _bit_indexes) if you plan to change
InsertZeroColumns's signature to take size_t as paremeters.

[brandtr, 2016-08-23 09:26:02]

https://codereview.webrtc.org/2269893002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/forward_error_correction.cc (right):

https://codereview.webrtc.org/2269893002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/forward_error_correction.cc:320: const uint16_t
num_zeros_to_insert =
On 2016/08/23 08:43:00, danilchap wrote:
> probably better to leave this type as int:
> variable represent count that is better to type as size_t or as int.
> InsertZeroColumns accepts it as int, so int look like better choice.
> cast next line is done for proper wrapping, not for proper typing.
> Alternatively change it to size_t (like with _bit_indexes) if you plan to
change
> InsertZeroColumns's signature to take size_t as paremeters.

Good call, I think I misunderstood line 321. Changing back to int for now.
Changing the types (and other general cleanup) in _internal is on my todo list,
but will have to wait for later on.

[stefan-webrtc, 2016-08-23 09:31:27]

lgtm

[brandtr, 2016-08-25 08:23:23]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2016-08-25 08:23:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2269893002/#ps20001 (title:
"Review response.")

[commit-bot: I haz the power, 2016-08-25 08:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 09:36:04]

Description was changed from

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is
used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654
==========

to

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is
used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654
==========

[commit-bot: I haz the power, 2016-08-25 09:36:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 09:36:17]

Description was changed from

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is
used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654
==========

to

==========
Move InsertZeroColumns and CopyColumn to ::internal.

These functions operate directly on the packet masks, and are thus not directly
involved in the FEC encoding/decoding operation. The ::internal namespace is
used
for packet mask-related functions, and will be renamed later on.

This CL should have no impact on functionality or performance.

BUG=webrtc:5654

Committed: https://crrev.com/00e45bb09d9d5e78b0dd614a1a28bbb98683fb1e
Cr-Commit-Position: refs/heads/master@{#13914}
==========

[commit-bot: I haz the power, 2016-08-25 09:36:18]

Patchset 2 (id:??) landed as
https://crrev.com/00e45bb09d9d5e78b0dd614a1a28bbb98683fb1e
Cr-Commit-Position: refs/heads/master@{#13914}