Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: webrtc/modules/rtp_rtcp/source/forward_error_correction.h

Issue 2269893002: Move InsertZeroColumns and CopyColumn to ::internal. (pt. 1) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review response. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/forward_error_correction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/forward_error_correction.h
diff --git a/webrtc/modules/rtp_rtcp/source/forward_error_correction.h b/webrtc/modules/rtp_rtcp/source/forward_error_correction.h
index 57eec7a01aaee2871407489400a55e25a6dc8b24..ac2cfa76b6f93c8cd54d496fa977903568e4ea35 100644
--- a/webrtc/modules/rtp_rtcp/source/forward_error_correction.h
+++ b/webrtc/modules/rtp_rtcp/source/forward_error_correction.h
@@ -229,26 +229,6 @@ class ForwardErrorCorrection {
uint8_t* packet_mask, int num_mask_bytes,
int num_fec_packets);
- // Inserts |num_zeros| zero columns into |new_mask| at position
- // |new_bit_index|. If the current byte of |new_mask| can't fit all zeros, the
- // byte will be filled with zeros from |new_bit_index|, but the next byte will
- // be untouched.
- static void InsertZeroColumns(int num_zeros, uint8_t* new_mask,
- int new_mask_bytes, int num_fec_packets,
- int new_bit_index);
-
- // Copies the left most bit column from the byte pointed to by
- // |old_bit_index| in |old_mask| to the right most column of the byte pointed
- // to by |new_bit_index| in |new_mask|. |old_mask_bytes| and |new_mask_bytes|
- // represent the number of bytes used per row for each mask. |num_fec_packets|
- // represent the number of rows of the masks.
- // The copied bit is shifted out from |old_mask| and is shifted one step to
- // the left in |new_mask|. |new_mask| will contain "xxxx xxn0" after this
- // operation, where x are previously inserted bits and n is the new bit.
- static void CopyColumn(uint8_t* new_mask, int new_mask_bytes,
- uint8_t* old_mask, int old_mask_bytes,
- int num_fec_packets, int new_bit_index,
- int old_bit_index);
void GenerateFecUlpHeaders(const PacketList& media_packets,
uint8_t* packet_mask, int num_fec_packets,
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/forward_error_correction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698