Renaming BaseChannel methods and adding comments for added clarity.

Renaming BaseChannel methods and adding comments for added clarity.

There were 3 different meanings for "ReadyToSend", for example, so it
was difficult to understand the meaning at first glance.

Also switching ASSERTs to RTC_DCHECKs.

Committed: https://crrev.com/bad33bf73b4b9c3be8e3e14c84f48e15ef3d265c
Cr-Commit-Position: refs/heads/master@{#13926}

[Taylor Brandstetter, 2016-08-24 23:40:34]

https://codereview.webrtc.org/2269173004/diff/1/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/2269173004/diff/1/webrtc/pc/channel.cc#newcode406
webrtc/pc/channel.cc:406: // BaseChannel could have resulted in an error), but
even so, we'll just
I know this comment is duplicated, but so is the rest of this method. I'm going
to fix that in a follow up CL, this CL is just focused on comments and renaming.

[Zhi Huang, 2016-08-25 17:28:27]

On 2016/08/24 23:40:34, Taylor Brandstetter wrote:
> https://codereview.webrtc.org/2269173004/diff/1/webrtc/pc/channel.cc
> File webrtc/pc/channel.cc (right):
> 
>
https://codereview.webrtc.org/2269173004/diff/1/webrtc/pc/channel.cc#newcode406
> webrtc/pc/channel.cc:406: // BaseChannel could have resulted in an error), but
> even so, we'll just
> I know this comment is duplicated, but so is the rest of this method. I'm
going
> to fix that in a follow up CL, this CL is just focused on comments and
renaming.

lgtm

[Taylor Brandstetter, 2016-08-25 18:19:20]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-25 18:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 20:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:20:01]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Taylor Brandstetter, 2016-08-25 20:31:29]

Description was changed from

==========
Renaming BaseChannel methods and adding comments for added clarity.

There were 3 different meanings for "ReadyToSend", for example, so it
was difficult to understand the meaning at first glance.

Also switching ASSERTs to RTC_DCHECKs.
==========

to

==========
Renaming BaseChannel methods and adding comments for added clarity.

There were 3 different meanings for "ReadyToSend", for example, so it
was difficult to understand the meaning at first glance.

Also switching ASSERTs to RTC_DCHECKs.

Committed:
https://chromium.googlesource.com/external/webrtc/+/bad33bf73b4b9c3be8e3e14c8...
==========

[Taylor Brandstetter, 2016-08-25 20:31:30]

Committed patchset #1 (id:1) manually as
bad33bf73b4b9c3be8e3e14c84f48e15ef3d265c (presubmit successful).

[commit-bot: I haz the power, 2016-08-25 20:31:31]

Description was changed from

==========
Renaming BaseChannel methods and adding comments for added clarity.

There were 3 different meanings for "ReadyToSend", for example, so it
was difficult to understand the meaning at first glance.

Also switching ASSERTs to RTC_DCHECKs.

Committed:
https://chromium.googlesource.com/external/webrtc/+/bad33bf73b4b9c3be8e3e14c8...
==========

to

==========
Renaming BaseChannel methods and adding comments for added clarity.

There were 3 different meanings for "ReadyToSend", for example, so it
was difficult to understand the meaning at first glance.

Also switching ASSERTs to RTC_DCHECKs.

Committed: https://crrev.com/bad33bf73b4b9c3be8e3e14c84f48e15ef3d265c
Cr-Commit-Position: refs/heads/master@{#13926}
==========