Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: webrtc/pc/channel_unittest.cc

Issue 2269173004: Renaming BaseChannel methods and adding comments for added clarity. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/pc/channel.cc ('K') | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel_unittest.cc
diff --git a/webrtc/pc/channel_unittest.cc b/webrtc/pc/channel_unittest.cc
index 7b30547a7e241a86c64aa1e3fc01ba9e5ca0f332..00382fab8e44582a561a80a44fa66eaa96a53384 100644
--- a/webrtc/pc/channel_unittest.cc
+++ b/webrtc/pc/channel_unittest.cc
@@ -1862,24 +1862,28 @@ class ChannelTest : public testing::Test, public sigslot::has_slots<> {
EXPECT_TRUE(media_channel1_->ready_to_send());
// rtp channel becomes not ready to send will be propagated to mediachannel
- network_thread_->Invoke<void>(
- RTC_FROM_HERE, [this] { channel1_->SetReadyToSend(false, false); });
+ network_thread_->Invoke<void>(RTC_FROM_HERE, [this] {
+ channel1_->SetTransportChannelReadyToSend(false, false);
+ });
WaitForThreads();
EXPECT_FALSE(media_channel1_->ready_to_send());
- network_thread_->Invoke<void>(
- RTC_FROM_HERE, [this] { channel1_->SetReadyToSend(false, true); });
+ network_thread_->Invoke<void>(RTC_FROM_HERE, [this] {
+ channel1_->SetTransportChannelReadyToSend(false, true);
+ });
WaitForThreads();
EXPECT_TRUE(media_channel1_->ready_to_send());
// rtcp channel becomes not ready to send will be propagated to mediachannel
- network_thread_->Invoke<void>(
- RTC_FROM_HERE, [this] { channel1_->SetReadyToSend(true, false); });
+ network_thread_->Invoke<void>(RTC_FROM_HERE, [this] {
+ channel1_->SetTransportChannelReadyToSend(true, false);
+ });
WaitForThreads();
EXPECT_FALSE(media_channel1_->ready_to_send());
- network_thread_->Invoke<void>(
- RTC_FROM_HERE, [this] { channel1_->SetReadyToSend(true, true); });
+ network_thread_->Invoke<void>(RTC_FROM_HERE, [this] {
+ channel1_->SetTransportChannelReadyToSend(true, true);
+ });
WaitForThreads();
EXPECT_TRUE(media_channel1_->ready_to_send());
}
@@ -1902,8 +1906,9 @@ class ChannelTest : public testing::Test, public sigslot::has_slots<> {
WaitForThreads();
EXPECT_TRUE(media_channel1_->ready_to_send());
- network_thread_->Invoke<void>(
- RTC_FROM_HERE, [this] { channel1_->SetReadyToSend(false, false); });
+ network_thread_->Invoke<void>(RTC_FROM_HERE, [this] {
+ channel1_->SetTransportChannelReadyToSend(false, false);
+ });
WaitForThreads();
EXPECT_FALSE(media_channel1_->ready_to_send());
}
« webrtc/pc/channel.cc ('K') | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698