Use swap instead of copy in RtcHistogram::GetAndReset.

Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283
Committed: https://crrev.com/1731c9cb4c4ea693ce836720dc64bed32cf6fe94
Cr-Commit-Position: refs/heads/master@{#15311}

[åsapersson, 2016-11-24 13:31:57]

Description was changed from

==========
Update rtc histograms:

- Update Reset (only used for testing) to use GetAndReset (and remove private
Reset functions).
- Add unit test for boolean histogram macro.
- Use std::move in GetAndReset

BUG=
==========

to

==========
Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283
==========

[åsapersson, 2016-11-24 13:31:57]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-11-28 15:15:55]

lg

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/metrics_default.cc (right):

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/metrics_default.cc:59: std::swap(info_.samples,
copy->samples);
Should we clear info_.samples after this?

[åsapersson, 2016-11-29 14:22:21]

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/metrics_default.cc (right):

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/metrics_default.cc:59: std::swap(info_.samples,
copy->samples);
On 2016/11/28 15:15:55, stefan-webrtc (holmer) wrote:
> Should we clear info_.samples after this?

copy->samples has an empty map before the swap.

[stefan-webrtc, 2016-11-29 16:15:53]

lgtm

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
File webrtc/system_wrappers/source/metrics_default.cc (right):

https://codereview.webrtc.org/2268323002/diff/40001/webrtc/system_wrappers/so...
webrtc/system_wrappers/source/metrics_default.cc:59: std::swap(info_.samples,
copy->samples);
On 2016/11/29 14:22:21, åsapersson wrote:
> On 2016/11/28 15:15:55, stefan-webrtc (holmer) wrote:
> > Should we clear info_.samples after this?
> 
> copy->samples has an empty map before the swap.

Acknowledged.

[åsapersson, 2016-11-30 08:11:15]

The CQ bit was checked by asapersson@webrtc.org

[commit-bot: I haz the power, 2016-11-30 08:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 08:29:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480493475151190,
"parent_rev": "751b7089f46aa2dab8037d5803dad05daf005cfb", "commit_rev":
"e116bc8515a56faf2cd97e8f980ffc7143a14e31"}

[commit-bot: I haz the power, 2016-11-30 08:29:11]

Description was changed from

==========
Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283
==========

to

==========
Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283
==========

[commit-bot: I haz the power, 2016-11-30 08:29:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 08:29:25]

Description was changed from

==========
Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283
==========

to

==========
Use swap instead of copy in RtcHistogram::GetAndReset.

BUG=webrtc:5283

Committed: https://crrev.com/1731c9cb4c4ea693ce836720dc64bed32cf6fe94
Cr-Commit-Position: refs/heads/master@{#15311}
==========

[commit-bot: I haz the power, 2016-11-30 08:29:26]

Patchset 3 (id:??) landed as
https://crrev.com/1731c9cb4c4ea693ce836720dc64bed32cf6fe94
Cr-Commit-Position: refs/heads/master@{#15311}