webrtc/system_wrappers/source/metrics_default_unittest.cc - Issue 2268323002: Use swap instead of copy in RtcHistogram::GetAndReset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/metrics_default_unittest.cc

Issue 2268323002: Use swap instead of copy in RtcHistogram::GetAndReset. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: remove Reset change Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/system_wrappers/source/metrics_default.cc ('K') | « webrtc/system_wrappers/source/metrics_default.cc ('k') | webrtc/system_wrappers/source/metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/system_wrappers/source/metrics_default_unittest.cc

diff --git a/webrtc/system_wrappers/source/metrics_default_unittest.cc b/webrtc/system_wrappers/source/metrics_default_unittest.cc

index c2eefe5563c06fefd56148f9cf71ca9ebe48774a..0414bc78f426061d42e520c847f9ff0bf0526bc0 100644

--- a/webrtc/system_wrappers/source/metrics_default_unittest.cc

+++ b/webrtc/system_wrappers/source/metrics_default_unittest.cc

@@ -134,6 +134,16 @@ TEST_F(MetricsDefaultTest, GetAndReset) {

EXPECT_EQ(1, NumEvents("Histogram1", 4, histograms));

EXPECT_EQ(2, NumEvents("Histogram1", 5, histograms));

EXPECT_EQ(1, NumEvents("Histogram2", 10, histograms));

+ // Add samples after reset.

+ metrics::GetAndReset(&histograms);

+ EXPECT_EQ(0u, histograms.size());

+ RTC_HISTOGRAM_PERCENTAGE("Histogram1", 50);

+ RTC_HISTOGRAM_PERCENTAGE("Histogram2", 8);

+ EXPECT_EQ(1, metrics::NumSamples("Histogram1"));

+ EXPECT_EQ(1, metrics::NumSamples("Histogram2"));

+ EXPECT_EQ(1, metrics::NumEvents("Histogram1", 50));

+ EXPECT_EQ(1, metrics::NumEvents("Histogram2", 8));

}

TEST_F(MetricsDefaultTest, TestMinMaxBucket) {