Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2266403005: Make neteq_rtpplay parse RTP header extensions (Closed)

Created:
4 years, 4 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-fake-decode-cng
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make neteq_rtpplay parse RTP header extensions This removes the warning printouts about unknown header extensions. BUG=webrtc:2692 Committed: https://crrev.com/8a6a600c165fe4c28d631114dcb84eecb693739d Cr-Commit-Position: refs/heads/master@{#13912}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M webrtc/modules/audio_coding/neteq/tools/neteq_packet_source_input.h View 4 chunks +8 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_packet_source_input.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 3 chunks +20 lines, -2 lines 2 comments Download

Depends on Patchset:

Issue 2275903002 Patch 1

Messages

Total messages: 13 (5 generated)
hlundin-webrtc
And one more...
4 years, 4 months ago (2016-08-24 07:07:49 UTC) #2
ivoc
LGTM, see nit below. https://codereview.webrtc.org/2266403005/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right): https://codereview.webrtc.org/2266403005/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc#newcode80 webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:80: printf("Invalid value for --%s: %d\n", ...
4 years, 4 months ago (2016-08-24 15:06:07 UTC) #3
hlundin-webrtc
https://codereview.webrtc.org/2266403005/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right): https://codereview.webrtc.org/2266403005/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc#newcode80 webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:80: printf("Invalid value for --%s: %d\n", flagname, static_cast<int>(value)); On 2016/08/24 ...
4 years, 4 months ago (2016-08-24 15:26:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2266403005/1
4 years, 4 months ago (2016-08-24 18:00:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-24 20:01:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2266403005/1
4 years, 3 months ago (2016-08-25 06:34:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 07:46:39 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 07:46:47 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8a6a600c165fe4c28d631114dcb84eecb693739d
Cr-Commit-Position: refs/heads/master@{#13912}

Powered by Google App Engine
This is Rietveld 408576698