Make FakeDecodeFromFile handle codec-internal CNG

Make FakeDecodeFromFile handle codec-internal CNG

This implementation interprets payloads of size 1 as codec-internal SID
frames, marking the start of a CNG period. Changes were made to other
parts of the test payload chain, since it had to make use of the virtual
payload size in the case of header-only RTP files.

BUG=webrtc:2692
Committed: https://crrev.com/d1a10a0f7795213210f9a9f5720167f97bade8c9
Cr-Commit-Position: refs/heads/master@{#13901}

[hlundin-webrtc, 2016-08-24 07:07:25]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2016-08-24 07:07:25]

Ivo, please, take a look at this update to the NetEq test tools.

[ivoc, 2016-08-24 14:55:28]

LGTM, see 2 nits below.

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.cc (right):

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.cc:54:
ByteReader<uint32_t>::ReadLittleEndian(&encoded[8]);
I think it makes sense to move this below to just before it is used in the if
statement.

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.h (right):

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.h:55: //
FakeDecpdeFromFile decoder will understand. |encoded| must be at least 12
Typo: FakeDecodeFromFile.

[hlundin-webrtc, 2016-08-24 15:18:35]

Fixing review comments

[hlundin-webrtc, 2016-08-24 15:27:36]

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.cc (right):

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.cc:54:
ByteReader<uint32_t>::ReadLittleEndian(&encoded[8]);
On 2016/08/24 14:55:28, ivoc wrote:
> I think it makes sense to move this below to just before it is used in the if
> statement.

Done.

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.h (right):

https://codereview.webrtc.org/2275903002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.h:55: //
FakeDecpdeFromFile decoder will understand. |encoded| must be at least 12
On 2016/08/24 14:55:28, ivoc wrote:
> Typo: FakeDecodeFromFile.

Done.

[hlundin-webrtc, 2016-08-24 15:27:48]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-08-24 15:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2275903002/#ps20001 (title:
"Fixing review comments")

[commit-bot: I haz the power, 2016-08-24 15:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 15:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:36:44]

Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/17346)

[hlundin-webrtc, 2016-08-24 15:47:18]

Fixing compile erros

[hlundin-webrtc, 2016-08-24 15:47:57]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-08-24 15:47:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2275903002/#ps40001 (title:
"Fixing compile errors")

[commit-bot: I haz the power, 2016-08-24 15:48:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 17:58:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 17:59:04]

Description was changed from

==========
Make FakeDecodeFromFile handle codec-internal CNG

This implementation interprets payloads of size 1 as codec-internal SID
frames, marking the start of a CNG period. Changes were made to other
parts of the test payload chain, since it had to make use of the virtual
payload size in the case of header-only RTP files.

BUG=webrtc:2692
==========

to

==========
Make FakeDecodeFromFile handle codec-internal CNG

This implementation interprets payloads of size 1 as codec-internal SID
frames, marking the start of a CNG period. Changes were made to other
parts of the test payload chain, since it had to make use of the virtual
payload size in the case of header-only RTP files.

BUG=webrtc:2692

Committed: https://crrev.com/d1a10a0f7795213210f9a9f5720167f97bade8c9
Cr-Commit-Position: refs/heads/master@{#13901}
==========

[commit-bot: I haz the power, 2016-08-24 17:59:05]

Patchset 3 (id:??) landed as
https://crrev.com/d1a10a0f7795213210f9a9f5720167f97bade8c9
Cr-Commit-Position: refs/heads/master@{#13901}