Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2264283003: MB: Flip Android bots to GN by default (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Flip Android bots to GN by default. Change the previous GN configs to build GYP instead (since we'll keep GYP around for a while) but exclude tests for that config from now on, since we're facing errors with GYP. Add new configs for upcoming rename of those bots to GYP instead of GN. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/4c8adb1ec70f5c68338536d8e5b2719da15e8271 Cr-Commit-Position: refs/heads/master@{#13875}

Patch Set 1 #

Patch Set 2 : Added TODO comments #

Patch Set 3 : Excluding tests for the Android GYP configs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -46 lines) Patch
M webrtc/build/mb_config.pyl View 1 2 4 chunks +59 lines, -46 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kjellander_webrtc
Tryjobs are passing in https://codereview.webrtc.org/2251693002/ for the same changes, so I don't think we need ...
4 years, 4 months ago (2016-08-23 20:28:41 UTC) #6
ehmaldonado_webrtc
On 2016/08/23 20:28:41, kjellander_webrtc wrote: > Tryjobs are passing in https://codereview.webrtc.org/2251693002/ for the same > ...
4 years, 4 months ago (2016-08-24 05:20:32 UTC) #8
kjellander_webrtc
On 2016/08/24 05:20:32, ehmaldonado_webrtc wrote: > On 2016/08/23 20:28:41, kjellander_webrtc wrote: > > Tryjobs are ...
4 years, 4 months ago (2016-08-24 05:56:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2264283003/80001
4 years, 4 months ago (2016-08-24 06:51:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 4 months ago (2016-08-24 07:34:44 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 07:35:05 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c8adb1ec70f5c68338536d8e5b2719da15e8271
Cr-Commit-Position: refs/heads/master@{#13875}

Powered by Google App Engine
This is Rietveld 408576698