Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2262443003: Delete VideoFrameFactory, CapturedFrame, and related code. (Closed)

Created:
4 years, 4 months ago by nisse-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, perkj_webrtc, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete VideoFrameFactory, CapturedFrame, and related code. BUG=webrtc:5682 Committed: https://crrev.com/66ac50e58c790624d51ede10ae438cbadbca9d2e Cr-Commit-Position: refs/heads/master@{#14315}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Update test code. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebased. #

Total comments: 8

Patch Set 6 : Address nits (questionable rotation logic not fixed). #

Patch Set 7 : Rebase. Undo media.gyp dependency change. #

Patch Set 8 : Improve rotation logic in OnFrame. #

Patch Set 9 : Update apply_rotation_ comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -615 lines) Patch
M webrtc/media/BUILD.gn View 1 2 3 4 5 6 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 1 2 3 4 5 6 3 chunks +25 lines, -40 lines 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 1 2 7 chunks +16 lines, -17 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 2 3 4 5 6 7 8 9 chunks +2 lines, -53 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 2 3 4 5 6 7 6 chunks +22 lines, -103 lines 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
D webrtc/media/base/videoframefactory.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/media/base/videoframefactory.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 2 3 4 3 chunks +4 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -72 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory.h View 1 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframefactory_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 38 (21 generated)
nisse-webrtc
4 years, 4 months ago (2016-08-19 13:31:06 UTC) #1
pthatcher1
https://codereview.webrtc.org/2262443003/diff/1/webrtc/media/base/fakevideocapturer.h File webrtc/media/base/fakevideocapturer.h (right): https://codereview.webrtc.org/2262443003/diff/1/webrtc/media/base/fakevideocapturer.h#newcode113 webrtc/media/base/fakevideocapturer.h:113: // TODO(nisse): XXX Keep to avoid warning. So are ...
4 years, 4 months ago (2016-08-23 00:13:15 UTC) #3
nisse-webrtc
Thanks for the comments, I wanted to show you where I'm aiming. I did a ...
4 years, 4 months ago (2016-08-23 06:46:40 UTC) #4
nisse-webrtc
https://codereview.webrtc.org/2262443003/diff/20001/webrtc/media/engine/webrtcvideoframe.h File webrtc/media/engine/webrtcvideoframe.h (right): https://codereview.webrtc.org/2262443003/diff/20001/webrtc/media/engine/webrtcvideoframe.h#newcode57 webrtc/media/engine/webrtcvideoframe.h:57: // only by the LoadFrame function used in the ...
4 years, 4 months ago (2016-08-24 12:19:54 UTC) #5
nisse-webrtc
Tests works for me now. ios bots are broken, because I haven't updated talk/app/webrtc/objc/avfoundationvideocapturer.mm to ...
4 years, 3 months ago (2016-08-29 13:42:59 UTC) #16
pthatcher1
https://codereview.webrtc.org/2262443003/diff/1/webrtc/media/base/videocapturer.h File webrtc/media/base/videocapturer.h (left): https://codereview.webrtc.org/2262443003/diff/1/webrtc/media/base/videocapturer.h#oldcode48 webrtc/media/base/videocapturer.h:48: struct CapturedFrame { On 2016/08/23 06:46:40, nisse-webrtc wrote: > ...
4 years, 3 months ago (2016-08-29 18:55:36 UTC) #17
pthatcher1
lgtm But can you add a comment about where apply_rotation_ is used, rather than having ...
4 years, 3 months ago (2016-09-07 18:03:03 UTC) #22
perkj_webrtc
https://codereview.webrtc.org/2262443003/diff/80001/webrtc/media/base/fakevideocapturer.h File webrtc/media/base/fakevideocapturer.h (right): https://codereview.webrtc.org/2262443003/diff/80001/webrtc/media/base/fakevideocapturer.h#newcode90 webrtc/media/base/fakevideocapturer.h:90: // class. Child classes of VideoFrameFactory are expected to ...
4 years, 3 months ago (2016-09-14 07:12:28 UTC) #23
nisse-webrtc
Easy nits addressed. https://codereview.webrtc.org/2262443003/diff/80001/webrtc/media/base/fakevideocapturer.h File webrtc/media/base/fakevideocapturer.h (right): https://codereview.webrtc.org/2262443003/diff/80001/webrtc/media/base/fakevideocapturer.h#newcode90 webrtc/media/base/fakevideocapturer.h:90: // class. Child classes of VideoFrameFactory ...
4 years, 3 months ago (2016-09-14 07:58:15 UTC) #24
nisse-webrtc
I have updated all dependencies I have found, and there have been some advance warning ...
4 years, 3 months ago (2016-09-20 07:45:10 UTC) #25
perkj_webrtc
lgtm
4 years, 3 months ago (2016-09-20 12:46:16 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2262443003/160001
4 years, 3 months ago (2016-09-20 13:08:22 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-20 15:08:59 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2262443003/160001
4 years, 3 months ago (2016-09-21 06:14:44 UTC) #33
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-09-21 06:51:39 UTC) #35
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/66ac50e58c790624d51ede10ae438cbadbca9d2e Cr-Commit-Position: refs/heads/master@{#14315}
4 years, 3 months ago (2016-09-21 06:51:58 UTC) #37
nisse-webrtc
4 years, 3 months ago (2016-09-21 09:09:34 UTC) #38
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.webrtc.org/2357113002/ by nisse@webrtc.org.

The reason for reverting is: Breaks downstream testcode, still using
CapturedFrame..

Powered by Google App Engine
This is Rietveld 408576698