Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Issue 2262173003: Add gtest as a dependency for neteq_quality_test_support. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add gtest as a dependency for neteq_quality_test_support. Was removed in Patch Set 5 of https://codereview.webrtc.org/2252413002 but shouldn't have been, since it's actually required. https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h?l=17 BUG=webrtc:6228 NOTRY=True Committed: https://crrev.com/6c46eaa5441efaad518bde18d4313ea7cb28e2d9 Cr-Commit-Position: refs/heads/master@{#13851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-22 15:49:18 UTC) #2
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-22 15:49:37 UTC) #4
kjellander_webrtc
lgtm, use NOTRY=True after firing a few compilation trybots.
4 years, 4 months ago (2016-08-22 16:18:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2262173003/1
4 years, 4 months ago (2016-08-22 16:46:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 16:48:07 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:48:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c46eaa5441efaad518bde18d4313ea7cb28e2d9
Cr-Commit-Position: refs/heads/master@{#13851}

Powered by Google App Engine
This is Rietveld 408576698