Refactor neteq_test_support.

Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True

Committed: https://crrev.com/861da3c662896ffb77754e396474ecc35b7f21d1
Cr-Commit-Position: refs/heads/master@{#13831}

[ehmaldonado_webrtc, 2016-08-18 14:53:05]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2016-08-18 14:53:05]

PTAL
I haven't filed a bug yet.

[hlundin-webrtc, 2016-08-18 15:09:11]

henrik.lundin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-08-18 15:09:11]

not lgtm

The flag validators look unused, but this is the pattern recommended in gflags
to define validators for flag values. See
https://github.com/gflags/gflags/blob/master/src/gflags.h.in#L108.

With your patch, invalid parameter values are no longer caught when the flags
are parsed.

[kjellander_webrtc, 2016-08-19 06:56:20]

Description was changed from

==========
Remove flag validators from neteq_quality_test.cc.

When built with GYP as a part of modules_unittests, these are never
invoked.

BUG=
==========

to

==========
Remove flag validators from neteq_quality_test.cc.

When built with GYP as a part of modules_unittests, these are never
invoked.

BUG=webrtc:6228
==========

[kjellander_webrtc, 2016-08-19 07:22:00]

On 2016/08/18 15:09:11, hlundin-webrtc wrote:
> not lgtm
> 
> The flag validators look unused, but this is the pattern recommended in gflags
> to define validators for flag values. See
> https://github.com/gflags/gflags/blob/master/src/gflags.h.in#L108.
> 
> With your patch, invalid parameter values are no longer caught when the flags
> are parsed.

I added BUG=webrtc:6228 to the CL description. I agree with Henrik L that just
removing all the validators is not the right solution here.
I think Edward did this CL because I said we need to be unblocked with the GN
migration, but there has to be a better explanation of why the validators are
behaving differently when built with GYP/GN. I posted a comment in
https://codereview.webrtc.org/2254143003/ with more information regarding why
they seem unused for modules_unittests.

[ehmaldonado_webrtc, 2016-08-19 08:09:56]

Patchset #2 (id:20001) has been deleted

[ehmaldonado_webrtc, 2016-08-19 09:14:29]

On 2016/08/19 07:22:00, kjellander_webrtc wrote:
> On 2016/08/18 15:09:11, hlundin-webrtc wrote:
> > not lgtm
> > 
> > The flag validators look unused, but this is the pattern recommended in
gflags
> > to define validators for flag values. See
> > https://github.com/gflags/gflags/blob/master/src/gflags.h.in#L108.
> > 
> > With your patch, invalid parameter values are no longer caught when the
flags
> > are parsed.
> 
> I added BUG=webrtc:6228 to the CL description. I agree with Henrik L that just
> removing all the validators is not the right solution here.
> I think Edward did this CL because I said we need to be unblocked with the GN
> migration, but there has to be a better explanation of why the validators are
> behaving differently when built with GYP/GN. I posted a comment in
> https://codereview.webrtc.org/2254143003/ with more information regarding why
> they seem unused for modules_unittests.

What would you think of something like this?
I've pulled 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' into
its
own target, neteq_quality_test_support, and add it to the tests that use it.

[ehmaldonado_webrtc, 2016-08-19 09:15:52]

Description was changed from

==========
Remove flag validators from neteq_quality_test.cc.

When built with GYP as a part of modules_unittests, these are never
invoked.

BUG=webrtc:6228
==========

to

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
==========

[kjellander_webrtc, 2016-08-19 09:16:18]

Lgtm if Henrik L is happy. Are all the dependencies for the new target needed.

[ehmaldonado_webrtc, 2016-08-19 09:17:03]

On 2016/08/19 09:16:18, kjellander_webrtc wrote:
> Lgtm if Henrik L is happy. Are all the dependencies for the new target needed.

Good question. I'll take a look.

[ehmaldonado_webrtc, 2016-08-19 09:53:58]

Patchset #5 (id:100001) has been deleted

[ehmaldonado_webrtc, 2016-08-19 09:54:55]

Patchset #5 (id:120001) has been deleted

[ehmaldonado_webrtc, 2016-08-19 09:55:54]

Patchset #4 (id:80001) has been deleted

[hlundin-webrtc, 2016-08-19 11:39:14]

lgtm

[ehmaldonado_webrtc, 2016-08-19 11:51:33]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-08-19 11:51:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2252413002/#ps160001 (title:
"Remove unused dependencies (2).")

[commit-bot: I haz the power, 2016-08-19 11:51:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-19 13:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:52:46]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ehmaldonado_webrtc, 2016-08-19 13:53:27]

Description was changed from

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
==========

to

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-08-19 13:53:33]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-08-19 13:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-19 14:02:27]

Description was changed from

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True
==========

to

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-19 14:02:28]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-08-19 14:02:36]

Description was changed from

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True
==========

to

==========
Refactor neteq_test_support.

Take 'tools/neteq_quality_test.cc' and 'tools/neteq_quality_test.h' outside of
neteq_test_support into their own target, neteq_quality_test_support.

BUG=webrtc:6228
NOTRY=True

Committed: https://crrev.com/861da3c662896ffb77754e396474ecc35b7f21d1
Cr-Commit-Position: refs/heads/master@{#13831}
==========

[commit-bot: I haz the power, 2016-08-19 14:02:38]

Patchset 5 (id:??) landed as
https://crrev.com/861da3c662896ffb77754e396474ecc35b7f21d1
Cr-Commit-Position: refs/heads/master@{#13831}