Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc

Issue 2260803002: Generalize FEC header formatting. (pt. 4) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc
diff --git a/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc b/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc
index fae59078b1fbd80385cfbc6e143074244be57997..ec8d0913313dea17d343d1778e48aaf6ff1aaa27 100644
--- a/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc
+++ b/webrtc/modules/rtp_rtcp/source/forward_error_correction_internal.cc
@@ -13,6 +13,9 @@
#include <assert.h>
#include <string.h>
+#include <algorithm>
+
+#include "webrtc/base/checks.h"
#include "webrtc/modules/rtp_rtcp/source/fec_private_tables_bursty.h"
#include "webrtc/modules/rtp_rtcp/source/fec_private_tables_random.h"
@@ -203,8 +206,8 @@ void RemainingPacketProtection(int num_media_packets,
const int l_bit =
(num_media_packets - num_fec_for_imp_packets) > 16 ? 1 : 0;
- const int res_mask_bytes =
- (l_bit == 1) ? kMaskSizeLBitSet : kMaskSizeLBitClear;
+ const int res_mask_bytes = (l_bit == 1) ? kUlpfecPacketMaskSizeLBitSet
+ : kUlpfecPacketMaskSizeLBitClear;
const uint8_t* packet_mask_sub_21 =
mask_table.fec_packet_mask_table()[num_media_packets -
@@ -244,8 +247,8 @@ void ImportantPacketProtection(int num_fec_for_imp_packets,
uint8_t* packet_mask,
const PacketMaskTable& mask_table) {
const int l_bit = num_imp_packets > 16 ? 1 : 0;
- const int num_imp_mask_bytes =
- (l_bit == 1) ? kMaskSizeLBitSet : kMaskSizeLBitClear;
+ const int num_imp_mask_bytes = (l_bit == 1) ? kUlpfecPacketMaskSizeLBitSet
+ : kUlpfecPacketMaskSizeLBitClear;
// Get sub_mask1 from table
const uint8_t* packet_mask_sub_1 =
@@ -374,8 +377,8 @@ void GeneratePacketMasks(int num_media_packets,
assert(num_imp_packets <= num_media_packets && num_imp_packets >= 0);
int l_bit = num_media_packets > 16 ? 1 : 0;
- const int num_mask_bytes =
- (l_bit == 1) ? kMaskSizeLBitSet : kMaskSizeLBitClear;
+ const int num_mask_bytes = (l_bit == 1) ? kUlpfecPacketMaskSizeLBitSet
+ : kUlpfecPacketMaskSizeLBitClear;
// Equal-protection for these cases.
if (!use_unequal_protection || num_imp_packets == 0) {
@@ -392,5 +395,46 @@ void GeneratePacketMasks(int num_media_packets,
} // End of UEP modification
} // End of GetPacketMasks
+size_t PacketMaskSize(size_t seq_num_spread) {
+ RTC_DCHECK_LE(seq_num_spread, 8 * kUlpfecPacketMaskSizeLBitSet);
+ if (seq_num_spread > 8 * kUlpfecPacketMaskSizeLBitClear) {
+ return kUlpfecPacketMaskSizeLBitSet;
+ } else {
+ return kUlpfecPacketMaskSizeLBitClear;
+ }
+}
+
+void InsertZeroColumns(int num_zeros,
+ uint8_t* new_mask,
+ int new_mask_bytes,
+ int num_fec_packets,
+ int new_bit_index) {
+ for (uint16_t row = 0; row < num_fec_packets; ++row) {
+ const int new_byte_index = row * new_mask_bytes + new_bit_index / 8;
+ const int max_shifts = (7 - (new_bit_index % 8));
+ new_mask[new_byte_index] <<= std::min(num_zeros, max_shifts);
+ }
+}
+
+void CopyColumn(uint8_t* new_mask,
+ int new_mask_bytes,
+ uint8_t* old_mask,
+ int old_mask_bytes,
+ int num_fec_packets,
+ int new_bit_index,
+ int old_bit_index) {
+ // Copy column from the old mask to the beginning of the new mask and shift it
+ // out from the old mask.
+ for (uint16_t row = 0; row < num_fec_packets; ++row) {
+ int new_byte_index = row * new_mask_bytes + new_bit_index / 8;
+ int old_byte_index = row * old_mask_bytes + old_bit_index / 8;
+ new_mask[new_byte_index] |= ((old_mask[old_byte_index] & 0x80) >> 7);
+ if (new_bit_index % 8 != 7) {
+ new_mask[new_byte_index] <<= 1;
+ }
+ old_mask[old_byte_index] <<= 1;
+ }
+}
+
} // namespace internal
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698