Generalize FEC header formatting. (pt. 4)

webrtc/modules/rtp_rtcp/source/producer_fec.h

Index: webrtc/modules/rtp_rtcp/source/producer_fec.h
diff --git a/webrtc/modules/rtp_rtcp/source/producer_fec.h b/webrtc/modules/rtp_rtcp/source/producer_fec.h
index a65bb053e0a9cfd03564e6adf62f2672e6e4ce4c..f09f18100cccbc7130edc5012a04f70e8ae398af 100644
--- a/webrtc/modules/rtp_rtcp/source/producer_fec.h
+++ b/webrtc/modules/rtp_rtcp/source/producer_fec.h
@@ -41,7 +41,7 @@ class RedPacket {
 
 class ProducerFec {
  public:
-  explicit ProducerFec(ForwardErrorCorrection* fec);
+  ProducerFec();

[danilchap, 2016/08/22 13:00:41]

Isn't this reducing genearlization or ProducerFec can work with ulpfec only?

[brandtr, 2016/08/23 08:19:11]

Correct, ProducerFec will only support Ulpfec. (In fact, that class will later
be renamed UlpfecSender). The reason for not generalizing the
{Ulp,Flex}fecSender and {Ulp,Flex}fecReceiver is that they do different things.
The Ulpfec classes will for example deal with RED packaging, which the Flexfec
classes will not.

   ~ProducerFec();
 
   static std::unique_ptr<RedPacket> BuildRedPacket(const uint8_t* data_buffer,
@@ -77,6 +77,8 @@ class ProducerFec {
 
   size_t NumAvailableFecPackets() const;
 
+  size_t MaxPacketOverhead() const;
+
   // Returns generated FEC packets with RED headers added.
   std::vector<std::unique_ptr<RedPacket>> GetFecPacketsAsRed(
       int red_payload_type,
@@ -87,7 +89,7 @@ class ProducerFec {
  private:
   void DeleteMediaPackets();
   int Overhead() const;
-  ForwardErrorCorrection* fec_;
+  ForwardErrorCorrection fec_;
   ForwardErrorCorrection::PacketList media_packets_;
   std::list<ForwardErrorCorrection::Packet*> generated_fec_packets_;
   int num_protected_frames_;