Change OverUseFrameDetector to use a task queue

Change OverUseFrameDetector to use a task queue instead of ProcessThread to periodically check for overuse. It is made to only operate on a single task queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687, webrtc:6289
TBR=mflodman@webrtc.org

Committed: https://crrev.com/d52063fb071b1d8cbe698ea0f5de6e6dddfacd72
Cr-Commit-Position: refs/heads/master@{#14107}

[perkj_webrtc, 2016-08-17 10:55:40]

Description was changed from

==========
Change OverUseFrameDetector to be created on a task queue and use the task queue
to process.

BUG=
==========

to

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687
==========

[perkj_webrtc, 2016-08-17 10:55:40]

perkj@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[perkj_webrtc, 2016-08-17 11:02:30]

please, when you have the time.

[åsapersson, 2016-08-24 08:59:05]

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:34: const int64_t
ktCheckForOveruseIntervalMs = 5000;
kCheck..?

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:231: RTC_DCHECK(!check_over_use_task_) <<
"StopCheckForOverUse must be called.";
nit: OverUse->Overuse

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:255:
RTC_DCHECK_CALLED_SEQUENTIALLY(&task_checker_);
Is the check needed for private methods?

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:281: int64_t time_when_first_seen) {
time_when_first_seen_ms

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:348: CpuOveruseMetrics current_metrics =
*metrics_;
remove current_metrics and use metrics_ instead?

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector.h (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:76: //
OverUseFrameDetector::StartCheckForOverUse  must be called to periodically
nit: OverUse->Overuse

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:90: // StopCheckForOverUse must be called
before destruction if
nit: OverUse->Overuse

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:95: void FrameCaptured(const VideoFrame&
frame, int64_t time_when_first_seen);
time_when_first_seen_ms

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:129: CheckOveruseTask*
check_over_use_task_;
maybe check_overuse_task_

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector_unittest.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector_unittest.cc:326: rtc::TaskQueue
queue("OveruseFrameDetectorTestQueu");
Queue

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/vie_encoder.cc
File webrtc/video/vie_encoder.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/vie_encoder....
webrtc/video/vie_encoder.cc:224: const int64_t time_when_posted_;
time_when_posted_ms_

[perkj_webrtc, 2016-09-01 10:03:30]

ptal

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:34: const int64_t
ktCheckForOveruseIntervalMs = 5000;
On 2016/08/24 08:59:04, åsapersson wrote:
> kCheck..?

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:231: RTC_DCHECK(!check_over_use_task_) <<
"StopCheckForOverUse must be called.";
On 2016/08/24 08:59:04, åsapersson wrote:
> nit: OverUse->Overuse

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:255:
RTC_DCHECK_CALLED_SEQUENTIALLY(&task_checker_);
On 2016/08/24 08:59:04, åsapersson wrote:
> Is the check needed for private methods?

Yes- , if you use GUARDED_BY(..) this is needed on all methods that access that
variable.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:281: int64_t time_when_first_seen) {
On 2016/08/24 08:59:04, åsapersson wrote:
> time_when_first_seen_ms

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.cc:348: CpuOveruseMetrics current_metrics =
*metrics_;
On 2016/08/24 08:59:04, åsapersson wrote:
> remove current_metrics and use metrics_ instead?

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector.h (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:76: //
OverUseFrameDetector::StartCheckForOverUse  must be called to periodically
On 2016/08/24 08:59:05, åsapersson wrote:
> nit: OverUse->Overuse

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:90: // StopCheckForOverUse must be called
before destruction if
On 2016/08/24 08:59:05, åsapersson wrote:
> nit: OverUse->Overuse

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:95: void FrameCaptured(const VideoFrame&
frame, int64_t time_when_first_seen);
On 2016/08/24 08:59:05, åsapersson wrote:
> time_when_first_seen_ms

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector.h:129: CheckOveruseTask*
check_over_use_task_;
On 2016/08/24 08:59:05, åsapersson wrote:
> maybe check_overuse_task_

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
File webrtc/video/overuse_frame_detector_unittest.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/overuse_fram...
webrtc/video/overuse_frame_detector_unittest.cc:326: rtc::TaskQueue
queue("OveruseFrameDetectorTestQueu");
On 2016/08/24 08:59:05, åsapersson wrote:
> Queue

Done.

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/vie_encoder.cc
File webrtc/video/vie_encoder.cc (right):

https://codereview.webrtc.org/2255463002/diff/60001/webrtc/video/vie_encoder....
webrtc/video/vie_encoder.cc:224: const int64_t time_when_posted_;
On 2016/08/24 08:59:05, åsapersson wrote:
> time_when_posted_ms_

Done.

[perkj_webrtc, 2016-09-01 10:57:40]

Description was changed from

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687
==========

to

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
==========

[åsapersson, 2016-09-02 11:07:58]

lgtm

[perkj_webrtc, 2016-09-02 12:18:48]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-09-02 12:18:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-02 13:01:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 13:01:39]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/8006)

[perkj_webrtc, 2016-09-02 19:12:32]

perkj@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[perkj_webrtc, 2016-09-02 19:12:33]

Need you again Magnus.

[perkj_webrtc, 2016-09-07 07:47:40]

Description was changed from

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
==========

to

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
TBR=mflodman@webrtc.org
==========

[perkj_webrtc, 2016-09-07 07:48:04]

mflodman - please take a look at this when you can.

[perkj_webrtc, 2016-09-07 07:48:11]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-09-07 07:48:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 09:48:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 09:48:38]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[perkj_webrtc, 2016-09-07 12:19:31]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-09-07 12:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 12:55:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 12:55:13]

Try jobs failed on following builders:
  linux_baremetal on master.tryserver.webrtc (JOB_FAILED, no build URL)

[perkj_webrtc, 2016-09-07 13:30:42]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-09-07 13:30:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-07 13:32:22]

Description was changed from

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
TBR=mflodman@webrtc.org
==========

to

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
TBR=mflodman@webrtc.org
==========

[commit-bot: I haz the power, 2016-09-07 13:32:23]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-07 13:32:27]

Description was changed from

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
TBR=mflodman@webrtc.org
==========

to

==========
Change OverUseFrameDetector to use a task queue instead of ProcessThread to
periodically check for overuse. It is made to only operate on a single task
queue.

With this cl, all methods are called on  the video encoder task queue.

BUG=webrtc:5687,webrtc:6289
TBR=mflodman@webrtc.org

Committed: https://crrev.com/d52063fb071b1d8cbe698ea0f5de6e6dddfacd72
Cr-Commit-Position: refs/heads/master@{#14107}
==========

[commit-bot: I haz the power, 2016-09-07 13:32:30]

Patchset 6 (id:??) landed as
https://crrev.com/d52063fb071b1d8cbe698ea0f5de6e6dddfacd72
Cr-Commit-Position: refs/heads/master@{#14107}