Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2250123002: Reland of Add task queue to Call. (Closed)

Created:
4 years, 4 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

This reverts commit 8eb37a39e79fe1098d3503dcb8c8c2d196203fed. Chrome now have its own implementation of TaskQueues that is based on Chrome threads. cl was originally reviewed here: https://codereview.webrtc.org/2060403002/ - Add task queue to Call with the intent of replacing the use of one of the process threads. - Split VideoSendStream in two. VideoSendStreamInternal is created and used on the new task queue. - BitrateAllocator is now created on libjingle's worker thread but always used on the new task queue instead of both encoder threads and the process thread. - VideoEncoderConfig and VideoSendStream::Config support move semantics. - The encoder thread is moved from VideoSendStream to ViEEncoder. Frames are forwarded directly to ViEEncoder which is responsible for timestamping ? and encoding the frames. TBR=mflodman@webrtc.org BUG=webrtc:5687, webrtc:6289, webrtc:4212 Committed: https://crrev.com/26091b1118e37b5cbbfe0de9869127fd5c1b01d0 Cr-Commit-Position: refs/heads/master@{#14014}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1683 lines, -1395 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 4 chunks +19 lines, -4 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 7 chunks +22 lines, -16 lines 0 comments Download
M webrtc/call.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 3 chunks +22 lines, -32 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 14 chunks +34 lines, -28 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/call/call.cc View 1 12 chunks +42 lines, -17 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/config.h View 2 chunks +13 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 3 chunks +7 lines, -8 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 4 chunks +12 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 6 chunks +11 lines, -10 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 11 chunks +15 lines, -12 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 1 2 6 chunks +8 lines, -7 lines 0 comments Download
M webrtc/video/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 11 chunks +22 lines, -21 lines 0 comments Download
D webrtc/video/video_capture_input.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/video/video_capture_input.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/video/video_capture_input_unittest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.h View 4 chunks +21 lines, -98 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 11 chunks +578 lines, -492 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 16 chunks +52 lines, -19 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 2 2 chunks +94 lines, -71 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 10 chunks +393 lines, -73 lines 0 comments Download
A webrtc/video/vie_encoder_unittest.cc View 1 chunk +255 lines, -0 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/video_send_stream.h View 5 chunks +22 lines, -6 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
perkj_webrtc
4 years, 3 months ago (2016-09-01 07:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2250123002/40001
4 years, 3 months ago (2016-09-01 07:41:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-01 08:17:44 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/26091b1118e37b5cbbfe0de9869127fd5c1b01d0 Cr-Commit-Position: refs/heads/master@{#14014}
4 years, 3 months ago (2016-09-01 08:17:52 UTC) #12
mflodman
4 years, 3 months ago (2016-09-08 09:24:01 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698