iLBC: Handle a case of bad input data

iLBC: Handle a case of bad input data

We detect an unreasonable state (caused by a bad encoded stream)
before it can lead to problems, and handle it by resetting the
decoder.

NOPRESUBMIT=true
BUG=chromium:617124
Committed: https://crrev.com/619a211562eeb43fdbed4085465a0ec36a08f221
Cr-Commit-Position: refs/heads/master@{#13888}

[kwiberg-webrtc, 2016-08-19 13:17:32]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-08-22 12:51:05]

Description was changed from

==========
iLBC: Handle a case of bad input data

We detect an unreasonable state (caused by a bad encoded stream)
before it can lead to problems, and handle it by resetting the
decoder.

BUG=chromium:617124
==========

to

==========
iLBC: Handle a case of bad input data

We detect an unreasonable state (caused by a bad encoded stream)
before it can lead to problems, and handle it by resetting the
decoder.

NOPRESUBMIT=true
BUG=chromium:617124
==========

[kwiberg-webrtc, 2016-08-22 12:51:54]

Patchset #1 (id:20001) has been deleted

[kwiberg-webrtc, 2016-08-22 13:06:34]

Patchset #1 (id:40001) has been deleted

[kwiberg-webrtc, 2016-08-22 13:11:43]

Patchset #1 (id:60001) has been deleted

[kwiberg-webrtc, 2016-08-22 13:26:41]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2016-08-22 13:26:42]

This uses the C implementation of RTC_CHECK from this CL:
https://codereview.webrtc.org/2262173002

[hlundin-webrtc, 2016-08-23 07:55:26]

LGTM with nits.

https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/ilbc/cb_construct.h (right):

https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/ilbc/cb_construct.h:28: // Returns true on
success, false on failure.
True, false, int. Will it blend...

https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h (right):

https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h:28: // Returns true on
success, false on failure. In case of failure, the decoder
Again, true, false and int...

[kwiberg-webrtc, 2016-08-23 12:00:41]

Patchset #2 (id:100001) has been deleted

[kwiberg-webrtc, 2016-08-23 12:44:04]

On 2016/08/23 07:55:26, hlundin-webrtc wrote:
> LGTM with nits.
> 
>
https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
> File webrtc/modules/audio_coding/codecs/ilbc/cb_construct.h (right):
> 
>
https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
> webrtc/modules/audio_coding/codecs/ilbc/cb_construct.h:28: // Returns true on
> success, false on failure.
> True, false, int. Will it blend...
> 
>
https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
> File webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h (right):
> 
>
https://codereview.webrtc.org/2255203002/diff/80001/webrtc/modules/audio_codi...
> webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h:28: // Returns true
on
> success, false on failure. In case of failure, the decoder
> Again, true, false and int...

How about this? It turns out that none of our bots dislike C99 anymore. Ain't it
grand?

[hlundin-webrtc, 2016-08-24 09:18:32]

lgtm

[kwiberg-webrtc, 2016-08-24 09:38:18]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-24 09:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 09:46:47]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-08-24 09:46:50]

Description was changed from

==========
iLBC: Handle a case of bad input data

We detect an unreasonable state (caused by a bad encoded stream)
before it can lead to problems, and handle it by resetting the
decoder.

NOPRESUBMIT=true
BUG=chromium:617124
==========

to

==========
iLBC: Handle a case of bad input data

We detect an unreasonable state (caused by a bad encoded stream)
before it can lead to problems, and handle it by resetting the
decoder.

NOPRESUBMIT=true
BUG=chromium:617124

Committed: https://crrev.com/619a211562eeb43fdbed4085465a0ec36a08f221
Cr-Commit-Position: refs/heads/master@{#13888}
==========

[commit-bot: I haz the power, 2016-08-24 09:46:51]

Patchset 2 (id:??) landed as
https://crrev.com/619a211562eeb43fdbed4085465a0ec36a08f221
Cr-Commit-Position: refs/heads/master@{#13888}