Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h

Issue 2255203002: iLBC: Handle a case of bad input data (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: bool test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
diff --git a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
index 67f05a57688b37cb114af509a5425aa6c985f392..38f896ec6d6e8e8f7ce70a56f7615d65cf02ad41 100644
--- a/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
+++ b/webrtc/modules/audio_coding/codecs/ilbc/decode_residual.h
@@ -19,20 +19,22 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_ILBC_MAIN_SOURCE_DECODE_RESIDUAL_H_
#define WEBRTC_MODULES_AUDIO_CODING_CODECS_ILBC_MAIN_SOURCE_DECODE_RESIDUAL_H_
+#include <stdbool.h>
#include "defines.h"
/*----------------------------------------------------------------*
* frame residual decoder function (subrutine to iLBC_decode)
*---------------------------------------------------------------*/
-void WebRtcIlbcfix_DecodeResidual(
- IlbcDecoder *iLBCdec_inst,
- /* (i/o) the decoder state structure */
- iLBC_bits *iLBC_encbits, /* (i/o) Encoded bits, which are used
- for the decoding */
- int16_t *decresidual, /* (o) decoded residual frame */
- int16_t *syntdenum /* (i) the decoded synthesis filter
- coefficients */
- );
+// Returns true on success, false on failure. In case of failure, the decoder
+// state may be corrupted and needs resetting.
+bool WebRtcIlbcfix_DecodeResidual(
+ IlbcDecoder* iLBCdec_inst, /* (i/o) the decoder state structure */
+ iLBC_bits* iLBC_encbits, /* (i/o) Encoded bits, which are used
+ for the decoding */
+ int16_t* decresidual, /* (o) decoded residual frame */
+ int16_t* syntdenum /* (i) the decoded synthesis filter
+ coefficients */
+ ) WARN_UNUSED_RESULT;
#endif
« no previous file with comments | « webrtc/modules/audio_coding/codecs/ilbc/decode.c ('k') | webrtc/modules/audio_coding/codecs/ilbc/decode_residual.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698