webrtc/api/peerconnectioninterface_unittest.cc - Issue 2254003002: Fixing off-by-one error with max SCTP id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/peerconnectioninterface_unittest.cc

Issue 2254003002: Fixing off-by-one error with max SCTP id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/peerconnectioninterface_unittest.cc

diff --git a/webrtc/api/peerconnectioninterface_unittest.cc b/webrtc/api/peerconnectioninterface_unittest.cc

index 0b24fcb7cfc4d119af78dacd4258d84f6188aa76..85b3649a2df521172ce4769e7d8abcbfae8aa8d3 100644

--- a/webrtc/api/peerconnectioninterface_unittest.cc

+++ b/webrtc/api/peerconnectioninterface_unittest.cc

@@ -1827,12 +1827,12 @@ TEST_F(PeerConnectionInterfaceTest,

channel = pc_->CreateDataChannel("x", &config);

EXPECT_TRUE(channel == NULL);

- config.id = cricket::kMaxSctpSid;

+ config.id = cricket::kMaxSctpStreams - 1;

channel = pc_->CreateDataChannel("max", &config);

EXPECT_TRUE(channel != NULL);

EXPECT_EQ(config.id, channel->id());

- config.id = cricket::kMaxSctpSid + 1;

+ config.id = cricket::kMaxSctpStreams;

channel = pc_->CreateDataChannel("x", &config);

EXPECT_TRUE(channel == NULL);

}