webrtc/api/webrtcsdp.cc - Issue 2254003002: Fixing off-by-one error with max SCTP id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsdp.cc

Issue 2254003002: Fixing off-by-one error with max SCTP id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/webrtcsdp.cc

diff --git a/webrtc/api/webrtcsdp.cc b/webrtc/api/webrtcsdp.cc

index 0b8d6f6a3d3fc28e4c4e6ba7d8de9655cc5234dc..0a2c8d79119e264eee99421302b3f90b32d404c8 100644

--- a/webrtc/api/webrtcsdp.cc

+++ b/webrtc/api/webrtcsdp.cc

@@ -1391,7 +1391,7 @@ void BuildSctpContentAttributes(std::string* message, int sctp_port) {

InitAttrLine(kAttributeSctpmap, &os);

os << kSdpDelimiterColon << sctp_port << kSdpDelimiterSpace

<< kDefaultSctpmapProtocol << kSdpDelimiterSpace

- << (cricket::kMaxSctpSid + 1);

+ << (cricket::kMaxSctpStreams);

skvlad 2016/08/17 19:13:53 The parentheses aren't necessary any more.

Taylor Brandstetter 2016/08/17 22:39:27 Done.

AddLine(os.str(), message);

}

« no previous file with comments | « webrtc/api/peerconnectioninterface_unittest.cc ('k') | webrtc/media/sctp/sctpdataengine.h » ('j') | no next file with comments »