Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2253563002: Add codec name to CodecSpecificInfo and get the codec name stats from there instead. (Closed)

Created:
4 years, 4 months ago by perkj_webrtc
Modified:
4 years, 3 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add codec name to CodecSpecificInfo and get the codec name stats from there instead. BUG=webrtc:5687 Committed: https://crrev.com/275afc5d2e3ce8f545b1164fcb52f4b5fbcce59b Cr-Commit-Position: refs/heads/master@{#14012}

Patch Set 1 #

Patch Set 2 : Fix fake_encoder.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -48 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 2 chunks +1 line, -9 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/video_encoder.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 4 chunks +22 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/video_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (14 generated)
perkj_webrtc
please? - Provided that Noah is ok with the fallback wrapper not reporting what it ...
4 years, 4 months ago (2016-08-16 11:44:21 UTC) #4
perkj_webrtc
Hi, can you please when you have the time?
4 years, 3 months ago (2016-08-23 08:50:41 UTC) #7
sprang_webrtc
lgtm
4 years, 3 months ago (2016-08-24 08:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2253563002/20001
4 years, 3 months ago (2016-08-25 06:48:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7694)
4 years, 3 months ago (2016-08-25 06:58:41 UTC) #12
perkj_webrtc
mflodman- needs review or owners approval. Should me and/or sprang be owners in any of ...
4 years, 3 months ago (2016-08-26 10:15:30 UTC) #14
mflodman
RS LGTM Yes, let's discuss and fix owners.
4 years, 3 months ago (2016-08-30 07:29:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2253563002/20001
4 years, 3 months ago (2016-08-30 11:10:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-08-30 13:10:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2253563002/20001
4 years, 3 months ago (2016-08-30 15:47:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-30 17:48:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2253563002/20001
4 years, 3 months ago (2016-09-01 06:26:00 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 07:21:21 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 07:21:23 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/275afc5d2e3ce8f545b1164fcb52f4b5fbcce59b
Cr-Commit-Position: refs/heads/master@{#14012}

Powered by Google App Engine
This is Rietveld 408576698