webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc - Issue 2253563002: Add codec name to CodecSpecificInfo and get the codec name stats from there instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 2253563002: Add codec name to CodecSpecificInfo and get the codec name stats from there instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix fake_encoder.cc Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc ('k') | webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

index 179081ae333fef4b3cc0e6fcbbd42bd31c7bb80e..dc32d3af4142ee2dae5e477983f206dbbe79d5dd 100644

--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

@@ -960,6 +960,7 @@ void VP8EncoderImpl::PopulateCodecSpecific(

bool only_predicting_from_key_frame) {

assert(codec_specific != NULL);

codec_specific->codecType = kVideoCodecVP8;

+ codec_specific->codec_name = ImplementationName();

CodecSpecificInfoVP8* vp8Info = &(codec_specific->codecSpecific.VP8);

vp8Info->pictureId = picture_id_[stream_idx];

if (pkt.data.frame.flags & VPX_FRAME_IS_KEY) {