webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm - Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

index 9c9fd75ac0908c815d3f40e0327a0c2229849e76..0ac2ec4c8a881d47dc68efb34c087e573d8db4ad 100644

--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

@@ -48,6 +48,19 @@

return self;

}

+- (BOOL)startAecDumpWithFileDescriptor:(int)fileDescriptor

+ maxFileSizeInBytes:(int)maxFileSizeInBytes {

+ // Pass the file to the recorder. The file ownership

+ // is passed to the recorder, and the recorder

+ // closes the file when needed.

+ return _nativeFactory->StartAecDump(fileDescriptor, maxFileSizeInBytes);

+- (void)stopAecDump {

+ // The file is closed by the call below.

+ _nativeFactory->StopAecDump();

- (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:

(nullable RTCMediaConstraints *)constraints {

return [[RTCAVFoundationVideoSource alloc] initWithFactory:self