webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm - Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m ('k') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm

diff --git a/webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm b/webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm

index 169f9991e1ab5cb2221ef3bdb6941432f6a7bb7f..355031e398ef35e020f61edf695e07c2b8c50b0b 100644

--- a/webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm

+++ b/webrtc/examples/objc/AppRTCDemo/tests/ARDAppClientTest.mm

@@ -283,8 +283,8 @@

weakAnswerer = answerer;

// Kick off connection.

- [caller connectToRoomWithId:roomId isLoopback:NO isAudioOnly:NO];

- [answerer connectToRoomWithId:roomId isLoopback:NO isAudioOnly:NO];

+ [caller connectToRoomWithId:roomId isLoopback:NO isAudioOnly:NO shouldMakeAecDump:NO];

+ [answerer connectToRoomWithId:roomId isLoopback:NO isAudioOnly:NO shouldMakeAecDump:NO];

[self waitForExpectationsWithTimeout:20 handler:^(NSError *error) {

if (error) {

NSLog(@"Expectations error: %@", error);