Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2250963002: Don't simulate probing based on rtc event logs since we don't have that info logged. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't simulate probing based on rtc event logs since we don't have that info logged. BUG=webrtc:6217 Committed: https://crrev.com/a93d5ac019ede2dcd3022785456c13815e40417c Cr-Commit-Position: refs/heads/master@{#13792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
stefan-webrtc
This caused the simulated BWE to look a lot different compared to the logged BWE. ...
4 years, 4 months ago (2016-08-17 07:45:42 UTC) #2
terelius
lgtm, but please create a bug. I would also like to know what the state ...
4 years, 4 months ago (2016-08-17 07:52:05 UTC) #3
stefan-webrtc
On 2016/08/17 07:52:05, terelius wrote: > lgtm, but please create a bug. I would also ...
4 years, 4 months ago (2016-08-17 07:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2250963002/1
4 years, 4 months ago (2016-08-17 07:53:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 09:14:36 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 09:14:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a93d5ac019ede2dcd3022785456c13815e40417c
Cr-Commit-Position: refs/heads/master@{#13792}

Powered by Google App Engine
This is Rietveld 408576698