Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: webrtc/examples/BUILD.gn

Issue 2250893003: GN: Add "//build/config/sanitizers:deps" to executable targets (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: In progress: Make linux sanitizer bots work in GN. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index 801ae0962f490b7e4142057b31dfeee7edac5c5a..3161d7f0f414e562c49b1d8e5dd3ee695e29837c 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -449,6 +449,7 @@ if (is_linux || is_win) {
"peerconnection/server/utils.h",
]
deps = [
+ "//build/config/sanitizers:deps",
kjellander_webrtc 2016/08/17 12:19:22 Don't you need to add this on all executables?
ehmaldonado_webrtc 2016/08/17 12:37:05 I'm not sure. I added this line to the targets it
kjellander_webrtc 2016/08/19 07:56:23 Ah, I guess it depends on what libraries they use.
ehmaldonado_webrtc 2016/08/19 08:16:06 Yes, you're right. Done.
"//webrtc:webrtc_common",
"//webrtc/base:rtc_base_approved",
"//webrtc/tools:command_line_parser",

Powered by Google App Engine
This is Rietveld 408576698