Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: webrtc/examples/BUILD.gn

Issue 2250893003: GN: Add "//build/config/sanitizers:deps" to executable targets (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: In progress: Make linux sanitizer bots work in GN. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 if (is_android) { 9 if (is_android) {
10 import("//build/config/android/config.gni") 10 import("//build/config/android/config.gni")
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 sources = [ 442 sources = [
443 "peerconnection/server/data_socket.cc", 443 "peerconnection/server/data_socket.cc",
444 "peerconnection/server/data_socket.h", 444 "peerconnection/server/data_socket.h",
445 "peerconnection/server/main.cc", 445 "peerconnection/server/main.cc",
446 "peerconnection/server/peer_channel.cc", 446 "peerconnection/server/peer_channel.cc",
447 "peerconnection/server/peer_channel.h", 447 "peerconnection/server/peer_channel.h",
448 "peerconnection/server/utils.cc", 448 "peerconnection/server/utils.cc",
449 "peerconnection/server/utils.h", 449 "peerconnection/server/utils.h",
450 ] 450 ]
451 deps = [ 451 deps = [
452 "//build/config/sanitizers:deps",
kjellander_webrtc 2016/08/17 12:19:22 Don't you need to add this on all executables?
ehmaldonado_webrtc 2016/08/17 12:37:05 I'm not sure. I added this line to the targets it
kjellander_webrtc 2016/08/19 07:56:23 Ah, I guess it depends on what libraries they use.
ehmaldonado_webrtc 2016/08/19 08:16:06 Yes, you're right. Done.
452 "//webrtc:webrtc_common", 453 "//webrtc:webrtc_common",
453 "//webrtc/base:rtc_base_approved", 454 "//webrtc/base:rtc_base_approved",
454 "//webrtc/tools:command_line_parser", 455 "//webrtc/tools:command_line_parser",
455 ] 456 ]
456 if (is_clang) { 457 if (is_clang) {
457 # Suppress warnings from the Chromium Clang plugin. 458 # Suppress warnings from the Chromium Clang plugin.
458 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 459 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
459 configs -= [ "//build/config/clang:find_bad_constructs" ] 460 configs -= [ "//build/config/clang:find_bad_constructs" ]
460 } 461 }
461 } 462 }
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 "//webrtc/system_wrappers:field_trial_default", 502 "//webrtc/system_wrappers:field_trial_default",
502 "//webrtc/system_wrappers:metrics_default", 503 "//webrtc/system_wrappers:metrics_default",
503 ] 504 ]
504 if (is_clang) { 505 if (is_clang) {
505 # Suppress warnings from the Chromium Clang plugin. 506 # Suppress warnings from the Chromium Clang plugin.
506 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. 507 # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
507 configs -= [ "//build/config/clang:find_bad_constructs" ] 508 configs -= [ "//build/config/clang:find_bad_constructs" ]
508 } 509 }
509 } 510 }
510 } 511 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698