Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2250893003:
GN: Add "//build/config/sanitizers:deps" to executable targets (Closed)
|
Created:
4 years, 4 months ago by ehmaldonado_webrtc Modified:
4 years, 4 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, danilchap, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhuangzesen_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN: Add "//build/config/sanitizers:deps" as a dependency to executable targets.
When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled.
BUG=webrtc:6215
NOTRY=True
Committed: https://crrev.com/bcba64a0fa90f0f1f8f94f82a3d55085c9f69fb7
Cr-Commit-Position: refs/heads/master@{#13829}
Patch Set 1 : In progress: Make linux sanitizer bots work in GN. #
Total comments: 18
Patch Set 2 : Addressed (some) comments. #Patch Set 3 : Added //build/config/sanitizers:deps to all executables. #Patch Set 4 : Switch linux trybots to GN for testing. #Patch Set 5 : Disable flag validation. #Patch Set 6 : Revert mb_config.pyl modification. #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== In progress: Make linux sanitizer bots work in GN. BUG=6215 ========== to ========== In progress: Make linux sanitizer bots work in GN. Don't submit before reverting mb_config.pyl BUG=6215 ==========
Patchset #1 (id:1) has been deleted
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org
There are still some issues.
But at least it compiles now.
ACTION //webrtc:rtc_event_log_proto_gen(//build/toolchain/linux:clang_x64)
../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error:
downcast of address 0x7ffc617f0d50 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<int, std::__1::basic_string<char>
>, void *>'
0x7ffc617f0d50: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 1c a9 20 02 00
00 00 00 00 aa 20 02
^
../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error:
downcast of address 0x7ffc617f1820 with insufficient space for an object of type
'std::__1::__tree_node<int, void *>'
0x7ffc617f1820: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e8 0a 86 00 00
00 00 00 00 00 00 00
^
../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error:
downcast of address 0x7ffc617f1940 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
const google::protobuf::Descriptor *>, void *>'
0x7ffc617f1940: note: pointer points here
00 00 00 00 e0 d5 1f 02 00 00 00 00 0f 00 00 00 00 00 00 00 20 5b 22 02 00
00 00 00 30 37 24 02
^
../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error:
downcast of address 0x7ffc617f16d0 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
std::__1::basic_string<char> >, void *>'
0x7ffc617f16d0: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0 38 24 02 00
00 00 00 c0 f2 1f 02
^
../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error:
downcast of address 0x7ffc617f1800 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
std::__1::basic_string<char> >, void *>'
0x7ffc617f1800: note: pointer points here
00 00 00 00 40 7c 25 02 00 00 00 00 12 00 00 00 00 00 00 00 12 63 6c 61 73
73 6e 61 6d 65 00 00
^
../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error:
downcast of address 0x7ffc617f1740 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
std::__1::basic_string<char> >, void *>'
0x7ffc617f1740: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 17 7f 61 01
00 00 00 50 46 24 02
^
../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error:
downcast of address 0x7ffc617f1740 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
std::__1::basic_string<char> >, void *>'
0x7ffc617f1740: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 17 7f 61 01
00 00 00 e0 46 24 02
^
../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error:
downcast of address 0x7ffc617f1738 with insufficient space for an object of type
'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>,
std::__1::basic_string<char> >, void *>'
0x7ffc617f1738: note: pointer points here
fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0 9d 1f 02 01
00 00 00 90 1a 7f 61
^
../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error:
downcast of address 0x7ffc617f18e8 with insufficient space for an object of type
'std::__1::__tree_node<int, void *>'
0x7ffc617f18e8: note: pointer points here
00 00 00 00 b0 d3 22 02 00 00 00 00 04 00 00 00 00 00 00 00 00 1a 7f 61 fc
7f 00 00 03 00 00 00
^
https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl
File webrtc/build/mb_config.pyl (right):
https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py...
webrtc/build/mb_config.pyl:1: # Copyright (c) 2016 The WebRTC project authors.
All Rights Reserved.
Changes in this file are not meant to be submitted. They are meant to test
locally the gn bots.
- Ignore goma
- Add gn bots for ubsan
https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/BUILD.gn (right):
https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/BUILD.gn:445: ":audioproc_debug_proto",
For the protobuf error I told you about.
> ACTION //webrtc:rtc_event_log_proto_gen(//build/toolchain/linux:clang_x64) > ../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error: > downcast of address 0x7ffc617f0d50 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<int, std::__1::basic_string<char> > >, void *>' > 0x7ffc617f0d50: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 1c a9 20 02 00 > 00 00 00 00 aa 20 02 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error: > downcast of address 0x7ffc617f1820 with insufficient space for an object of type > 'std::__1::__tree_node<int, void *>' > 0x7ffc617f1820: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e8 0a 86 00 00 > 00 00 00 00 00 00 00 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error: > downcast of address 0x7ffc617f1940 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > const google::protobuf::Descriptor *>, void *>' > 0x7ffc617f1940: note: pointer points here > 00 00 00 00 e0 d5 1f 02 00 00 00 00 0f 00 00 00 00 00 00 00 20 5b 22 02 00 > 00 00 00 30 37 24 02 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error: > downcast of address 0x7ffc617f16d0 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > std::__1::basic_string<char> >, void *>' > 0x7ffc617f16d0: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0 38 24 02 00 > 00 00 00 c0 f2 1f 02 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error: > downcast of address 0x7ffc617f1800 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > std::__1::basic_string<char> >, void *>' > 0x7ffc617f1800: note: pointer points here > 00 00 00 00 40 7c 25 02 00 00 00 00 12 00 00 00 00 00 00 00 12 63 6c 61 73 > 73 6e 61 6d 65 00 00 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error: > downcast of address 0x7ffc617f1740 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > std::__1::basic_string<char> >, void *>' > 0x7ffc617f1740: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 17 7f 61 01 > 00 00 00 50 46 24 02 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error: > downcast of address 0x7ffc617f1740 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > std::__1::basic_string<char> >, void *>' > 0x7ffc617f1740: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 17 7f 61 01 > 00 00 00 e0 46 24 02 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:844:16: runtime error: > downcast of address 0x7ffc617f1738 with insufficient space for an object of type > 'std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, > std::__1::basic_string<char> >, void *>' > 0x7ffc617f1738: note: pointer points here > fc 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b0 9d 1f 02 01 > 00 00 00 90 1a 7f 61 > ^ > ../../buildtools/third_party/libc++/trunk/include/__tree:836:16: runtime error: > downcast of address 0x7ffc617f18e8 with insufficient space for an object of type > 'std::__1::__tree_node<int, void *>' > 0x7ffc617f18e8: note: pointer points here > 00 00 00 00 b0 d3 22 02 00 00 00 00 04 00 00 00 00 00 00 00 00 1a 7f 61 fc > 7f 00 00 03 00 00 00 > ^ I haven't tried compiling it in GYP, so I don't know if this is also a problem there.
With my suggested changes to mb_config.pyl addressed, you'll be able to properly test this CL on the linux_*san trybots. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (left): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:388: 'goma': { Does Goma change the result or why did you remove it? I'm just curious (I know you're not intending to submit the mb_config.pyl changes). https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:51: 'Linux UBSan (GN)': 'gn_ubsan_clang_release_bot_x64', This won't change anything if you run this at tryjobs. To be able to test this properly, you need to change the MB configs for the trybots, similar to my https://codereview.webrtc.org/2251693002/ https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:452: "//build/config/sanitizers:deps", Don't you need to add this on all executables? https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... webrtc/modules/audio_coding/BUILD.gn:1134: "//build/config/sanitizers:deps", Shouldn't be needed for targets using the test template. Sure it's needed? https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... webrtc/modules/audio_coding/BUILD.gn:1407: "../../test:test_support_main", Missing for this target (and others in this file). https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/BUILD.gn:445: ":audioproc_debug_proto", On 2016/08/17 11:32:17, ehmaldonado_webrtc wrote: > For the protobuf error I told you about. Ah, this was an error. Since the GYP target only depends on :audioproc_debug_proto I think you should remove :audioproc_unittest_proto to make them similar. See https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_process...
I'm not sure if we need to add that line to all executables. I added to the ones it was complaining about. I'll do that in another patch, better safe than sorry :) The changes to the mb_config.pyl were mainly because presubmit was complaining that the configs were not being used, but testing it on the linux_*san bots is a good idea :) https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (left): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:388: 'goma': { On 2016/08/17 12:19:22, kjellander_webrtc wrote: > Does Goma change the result or why did you remove it? I'm just curious (I know > you're not intending to submit the mb_config.pyl changes). I don't have goma locally. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:51: 'Linux UBSan (GN)': 'gn_ubsan_clang_release_bot_x64', On 2016/08/17 12:19:22, kjellander_webrtc wrote: > This won't change anything if you run this at tryjobs. > To be able to test this properly, you need to change the MB configs for the > trybots, similar to my https://codereview.webrtc.org/2251693002/ Oh, I only meant to use mb locally to generate both gn and gyp. These changes was because presubmit.py was complaining that the configs weren't used. But that's actually a good idea. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:452: "//build/config/sanitizers:deps", On 2016/08/17 12:19:22, kjellander_webrtc wrote: > Don't you need to add this on all executables? I'm not sure. I added this line to the targets it complained about. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... webrtc/modules/audio_coding/BUILD.gn:1134: "//build/config/sanitizers:deps", On 2016/08/17 12:19:22, kjellander_webrtc wrote: > Shouldn't be needed for targets using the test template. Sure it's needed? You're right, sorry. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... webrtc/modules/audio_coding/BUILD.gn:1407: "../../test:test_support_main", On 2016/08/17 12:19:22, kjellander_webrtc wrote: > Missing for this target (and others in this file). Ok, I'll do, but I'm not sure if it's really needed.
Patchset #5 (id:100001) has been deleted
Patchset #5 (id:120001) has been deleted
Patchset #5 (id:140001) has been deleted
Description was changed from ========== In progress: Make linux sanitizer bots work in GN. Don't submit before reverting mb_config.pyl BUG=6215 ========== to ========== In progress: Make linux sanitizer bots work in GN. Don't submit before reverting mb_config.pyl BUG=webrtc:6215 ==========
On 2016/08/17 12:37:05, ehmaldonado_webrtc wrote: > I'm not sure if we need to add that line to all executables. I added to the ones > it was complaining about. I'll do that in another patch, better safe than sorry > :) > > The changes to the mb_config.pyl were mainly because presubmit was complaining > that the configs were not being used, but testing it on the linux_*san bots is a > good idea :) > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl > File webrtc/build/mb_config.pyl (left): > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... > webrtc/build/mb_config.pyl:388: 'goma': { > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Does Goma change the result or why did you remove it? I'm just curious (I know > > you're not intending to submit the mb_config.pyl changes). > > I don't have goma locally. > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl > File webrtc/build/mb_config.pyl (right): > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... > webrtc/build/mb_config.pyl:51: 'Linux UBSan (GN)': > 'gn_ubsan_clang_release_bot_x64', > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > This won't change anything if you run this at tryjobs. > > To be able to test this properly, you need to change the MB configs for the > > trybots, similar to my https://codereview.webrtc.org/2251693002/ > > Oh, I only meant to use mb locally to generate both gn and gyp. These changes > was because presubmit.py was complaining that the configs weren't used. > > But that's actually a good idea. > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn > File webrtc/examples/BUILD.gn (right): > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn#... > webrtc/examples/BUILD.gn:452: "//build/config/sanitizers:deps", > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Don't you need to add this on all executables? > > I'm not sure. I added this line to the targets it complained about. > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... > File webrtc/modules/audio_coding/BUILD.gn (right): > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... > webrtc/modules/audio_coding/BUILD.gn:1134: "//build/config/sanitizers:deps", > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Shouldn't be needed for targets using the test template. Sure it's needed? > > You're right, sorry. > > https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_codi... > webrtc/modules/audio_coding/BUILD.gn:1407: "../../test:test_support_main", > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Missing for this target (and others in this file). > > Ok, I'll do, but I'm not sure if it's really needed. Should we clean up this CL and commit it?
Yes please. I forgot I had two unpublished comments as well. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (left): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:388: 'goma': { On 2016/08/17 12:37:05, ehmaldonado_webrtc wrote: > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Does Goma change the result or why did you remove it? I'm just curious (I know > > you're not intending to submit the mb_config.pyl changes). > > I don't have goma locally. You should, to speed up compilation. Check out go/ma. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:452: "//build/config/sanitizers:deps", On 2016/08/17 12:37:05, ehmaldonado_webrtc wrote: > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > Don't you need to add this on all executables? > > I'm not sure. I added this line to the targets it complained about. Ah, I guess it depends on what libraries they use. I'd vote for adding it everywhere but i could also wait until we introduce the rtc_executable template. Feel free to skip wasting time on this now as it's not that important (although confusing when users add new targets, copying an existing one but might run into the sanitizer error).
Description was changed from ========== In progress: Make linux sanitizer bots work in GN. Don't submit before reverting mb_config.pyl BUG=webrtc:6215 ========== to ========== GN: Add "//build/config/sanitizers:deps" as a dependency to executable targets. When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled. BUG=webrtc:6215 NOTRY=True ==========
PTAL. I changed the issue's descrption, started some trybots and added NOTRY=True. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (left): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/build/mb_config.py... webrtc/build/mb_config.pyl:388: 'goma': { On 2016/08/19 07:56:23, kjellander_webrtc wrote: > On 2016/08/17 12:37:05, ehmaldonado_webrtc wrote: > > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > > Does Goma change the result or why did you remove it? I'm just curious (I > know > > > you're not intending to submit the mb_config.pyl changes). > > > > I don't have goma locally. > > You should, to speed up compilation. Check out go/ma. Ok, I'll take a look, thanks :) https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn File webrtc/examples/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/examples/BUILD.gn#... webrtc/examples/BUILD.gn:452: "//build/config/sanitizers:deps", On 2016/08/19 07:56:23, kjellander_webrtc wrote: > On 2016/08/17 12:37:05, ehmaldonado_webrtc wrote: > > On 2016/08/17 12:19:22, kjellander_webrtc wrote: > > > Don't you need to add this on all executables? > > > > I'm not sure. I added this line to the targets it complained about. > > Ah, I guess it depends on what libraries they use. I'd vote for adding it > everywhere but i could also wait until we introduce the rtc_executable template. > Feel free to skip wasting time on this now as it's not that important (although > confusing when users add new targets, copying an existing one but might run into > the sanitizer error). Yes, you're right. Done. https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/BUILD.gn (right): https://codereview.webrtc.org/2250893003/diff/20001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/BUILD.gn:445: ":audioproc_debug_proto", On 2016/08/17 12:19:22, kjellander_webrtc wrote: > On 2016/08/17 11:32:17, ehmaldonado_webrtc wrote: > > For the protobuf error I told you about. > > Ah, this was an error. Since the GYP target only depends on > :audioproc_debug_proto I think you should remove :audioproc_unittest_proto to > make them similar. See > https://cs.chromium.org/chromium/src/third_party/webrtc/modules/audio_process... > Done.
lgtm
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== GN: Add "//build/config/sanitizers:deps" as a dependency to executable targets. When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled. BUG=webrtc:6215 NOTRY=True ========== to ========== GN: Add "//build/config/sanitizers:deps" as a dependency to executable targets. When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled. BUG=webrtc:6215 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #6 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== GN: Add "//build/config/sanitizers:deps" as a dependency to executable targets. When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled. BUG=webrtc:6215 NOTRY=True ========== to ========== GN: Add "//build/config/sanitizers:deps" as a dependency to executable targets. When the sanitizer bots are switched to GN, this needs to be included as a dependency so that the executables can be compiled. BUG=webrtc:6215 NOTRY=True Committed: https://crrev.com/bcba64a0fa90f0f1f8f94f82a3d55085c9f69fb7 Cr-Commit-Position: refs/heads/master@{#13829} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/bcba64a0fa90f0f1f8f94f82a3d55085c9f69fb7 Cr-Commit-Position: refs/heads/master@{#13829} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
