Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2248713003: Revert of Add task queue to Call. (Closed)

Created:
4 years, 4 months ago by perkj_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@move_getpadding
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add task queue to Call. (patchset #42 id:840001 of https://codereview.webrtc.org/2060403002/ ) Reason for revert: Failed on Win 10 Chrome FYI. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/3847/steps/content_browsertests/logs/stdio # # Fatal error in e:\b\c\b\win_builder\src\third_party\webrtc\base\task_queue_win.cc, line 138 # last system error: 87 # Check failed: ((DWORD)0xFFFFFFFF) != result (4294967295 vs. 4294967295) # WebRtcBrowserTest # Original issue's description: > - Add task queue to Call with the intent of replacing the use of one of the process threads. > > - Split VideoSendStream in two. VideoSendStreamInternal is created and used on the new task queue. > > - BitrateAllocator is now created on libjingle's worker thread but always used on the new task queue instead of both encoder threads and the process thread. > > - VideoEncoderConfig and VideoSendStream::Config support move semantics. > > - The encoder thread is moved from VideoSendStream to ViEEncoder. Frames are forwarded directly to ViEEncoder which is responsible for timestamping ? and encoding the frames. > > BUG=webrtc:5687 > > Committed: https://crrev.com/cc168360f41322332860cb075edeb1cde21aa473 > Cr-Commit-Position: refs/heads/master@{#13767} TBR=tommi@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org,sprang@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/8eb37a39e79fe1098d3503dcb8c8c2d196203fed Cr-Commit-Position: refs/heads/master@{#13774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1435 lines, -1722 lines) Patch
M webrtc/audio/audio_send_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 4 chunks +4 lines, -19 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 7 chunks +16 lines, -22 lines 0 comments Download
M webrtc/call.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/call/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 3 chunks +32 lines, -22 lines 0 comments Download
M webrtc/call/bitrate_allocator.cc View 14 chunks +30 lines, -36 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/call/call.cc View 12 chunks +17 lines, -42 lines 0 comments Download
M webrtc/call/call_perf_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/config.h View 2 chunks +0 lines, -13 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 3 chunks +8 lines, -7 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 11 chunks +12 lines, -15 lines 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M webrtc/video/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 11 chunks +23 lines, -24 lines 0 comments Download
A webrtc/video/video_capture_input.h View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/video/video_capture_input.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A webrtc/video/video_capture_input_unittest.cc View 1 chunk +255 lines, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.h View 4 chunks +98 lines, -21 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 11 chunks +519 lines, -605 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 15 chunks +19 lines, -52 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +72 lines, -94 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 10 chunks +79 lines, -399 lines 0 comments Download
D webrtc/video/vie_encoder_unittest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video_send_stream.h View 5 chunks +6 lines, -22 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of Add task queue to Call.
4 years, 4 months ago (2016-08-16 09:40:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2248713003/1
4 years, 4 months ago (2016-08-16 09:40:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 09:40:59 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 09:41:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8eb37a39e79fe1098d3503dcb8c8c2d196203fed
Cr-Commit-Position: refs/heads/master@{#13774}

Powered by Google App Engine
This is Rietveld 408576698