Return nil from RTCPeerConnectionFactory when creation fails

Return nil from RTCPeerConnectionFactory when creation fails

RTCPeerConnectionFactory.createPeerConnection did not check the return
value of the native createPeerConnection() - so when the native PC
fails to be created, it could end up attempting to use a null pointer.

The change makes it return nil when the creation fails. The application
can then detect and respond to the failure.

Committed: https://crrev.com/588783adcd2bcf1a788cfd318e1394f241e9a78f
Cr-Commit-Position: refs/heads/master@{#13732}

[skvlad, 2016-08-11 19:36:45]

skvlad@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-08-11 19:48:24]

lgtm

[skvlad, 2016-08-11 19:48:53]

The CQ bit was checked by skvlad@webrtc.org

[commit-bot: I haz the power, 2016-08-11 19:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-11 21:29:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-11 21:29:38]

Description was changed from

==========
Return nil from RTCPeerConnectionFactory when creation fails

RTCPeerConnectionFactory.createPeerConnection did not check the return
value of the native createPeerConnection() - so when the native PC
fails to be created, it could end up attempting to use a null pointer.

The change makes it return nil when the creation fails. The application
can then detect and respond to the failure.
==========

to

==========
Return nil from RTCPeerConnectionFactory when creation fails

RTCPeerConnectionFactory.createPeerConnection did not check the return
value of the native createPeerConnection() - so when the native PC
fails to be created, it could end up attempting to use a null pointer.

The change makes it return nil when the creation fails. The application
can then detect and respond to the failure.

Committed: https://crrev.com/588783adcd2bcf1a788cfd318e1394f241e9a78f
Cr-Commit-Position: refs/heads/master@{#13732}
==========

[commit-bot: I haz the power, 2016-08-11 21:29:38]

Patchset 1 (id:??) landed as
https://crrev.com/588783adcd2bcf1a788cfd318e1394f241e9a78f
Cr-Commit-Position: refs/heads/master@{#13732}