webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm - Issue 2240633004: Return nil from RTCPeerConnectionFactory when creation fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm

Issue 2240633004: Return nil from RTCPeerConnectionFactory when creation fails (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm

index 99a0db3d76ab86e5219984b8f8646d6b3eea2aec..428eb2496f5cceaad1e754b8bb19197de19c1005 100644

--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm

+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm

@@ -232,6 +232,9 @@ void PeerConnectionDelegateAdapter::OnIceCandidatesRemoved(

nullptr,

_observer.get());

+ if (!_peerConnection) {

+ return nil;

+ }

_localStreams = [[NSMutableArray alloc] init];

_delegate = delegate;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »