Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2237853002: Remove obosolete SessionId setter/getter from PortAllocator. (Closed)

Created:
4 years, 4 months ago by johan
Modified:
4 years, 4 months ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused SessionId from TransportChannel and PortAllocatorSession. BUG= Committed: https://crrev.com/fe1ffb141bd6e9ce010346e4dd5d44054e57338e Cr-Commit-Position: refs/heads/master@{#13731}

Patch Set 1 #

Patch Set 2 : Remove deprecation include again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
johan
4 years, 4 months ago (2016-08-11 14:01:02 UTC) #3
pthatcher1
lgtm
4 years, 4 months ago (2016-08-11 14:31:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2237853002/20001
4 years, 4 months ago (2016-08-11 14:36:45 UTC) #8
honghaiz3
lgtm
4 years, 4 months ago (2016-08-11 15:34:20 UTC) #10
honghaiz3
lgtm lgtm
4 years, 4 months ago (2016-08-11 15:34:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2237853002/20001
4 years, 4 months ago (2016-08-11 16:07:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-11 16:37:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2237853002/20001
4 years, 4 months ago (2016-08-11 19:28:20 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 19:37:51 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 19:37:56 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe1ffb141bd6e9ce010346e4dd5d44054e57338e
Cr-Commit-Position: refs/heads/master@{#13731}

Powered by Google App Engine
This is Rietveld 408576698