Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: webrtc/p2p/base/portallocator_unittest.cc

Issue 2237853002: Remove obosolete SessionId setter/getter from PortAllocator. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove deprecation include again. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/portallocator.cc ('k') | webrtc/p2p/base/transportchannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/portallocator_unittest.cc
diff --git a/webrtc/p2p/base/portallocator_unittest.cc b/webrtc/p2p/base/portallocator_unittest.cc
index 06abaad2a08edcc941471e5f04d50b5712f6d260..a97cf305b7330c766f979406e71fd4a16a73b15c 100644
--- a/webrtc/p2p/base/portallocator_unittest.cc
+++ b/webrtc/p2p/base/portallocator_unittest.cc
@@ -15,7 +15,6 @@
#include "webrtc/p2p/base/fakeportallocator.h"
#include "webrtc/p2p/base/portallocator.h"
-static const char kSessionId[] = "session id";
static const char kContentName[] = "test content";
// Based on ICE_UFRAG_LENGTH
static const char kIceUfrag[] = "UF00";
@@ -39,7 +38,6 @@ class PortAllocatorTest : public testing::Test, public sigslot::has_slots<> {
}
std::unique_ptr<cricket::FakePortAllocatorSession> CreateSession(
- const std::string& sid,
const std::string& content_name,
int component,
const std::string& ice_ufrag,
@@ -47,8 +45,7 @@ class PortAllocatorTest : public testing::Test, public sigslot::has_slots<> {
return std::unique_ptr<cricket::FakePortAllocatorSession>(
static_cast<cricket::FakePortAllocatorSession*>(
allocator_
- ->CreateSession(sid, content_name, component, ice_ufrag,
- ice_pwd)
+ ->CreateSession(content_name, component, ice_ufrag, ice_pwd)
.release()));
}
@@ -95,7 +92,7 @@ TEST_F(PortAllocatorTest, TestDefaults) {
// candidate filter are applied as expected.
TEST_F(PortAllocatorTest, CreateSession) {
allocator_->set_candidate_filter(cricket::CF_RELAY);
- auto session = CreateSession(kSessionId, kContentName, 1, kIceUfrag, kIcePwd);
+ auto session = CreateSession(kContentName, 1, kIceUfrag, kIcePwd);
ASSERT_NE(nullptr, session);
EXPECT_EQ(cricket::CF_RELAY, session->candidate_filter());
EXPECT_EQ(kContentName, session->content_name());
« no previous file with comments | « webrtc/p2p/base/portallocator.cc ('k') | webrtc/p2p/base/transportchannel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698