Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2236573002: MB: Make all Android debug builds static (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Make all Android debug builds static In https://codereview.webrtc.org/2228923002 all Android debug bots were configured to build with component=shared_library. This is not the behavior we had before: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/config.py?rcl=0&l=713 This CL changes them back to static library. BUG=589510 NOTRY=True TBR=ehmaldonado@webrtc.org Committed: https://crrev.com/68815bf97722ccc2389a9f9b7cf4d9411b92db98 Cr-Commit-Position: refs/heads/master@{#13718}

Patch Set 1 #

Patch Set 2 : Fixed one missing rename #

Patch Set 3 : Last one :P #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M webrtc/build/mb_config.pyl View 1 2 5 chunks +39 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Seems impossible to get this right the first time - wading in different configs!
4 years, 4 months ago (2016-08-10 16:47:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2236573002/40001
4 years, 4 months ago (2016-08-10 16:48:03 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 16:49:42 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:49:48 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68815bf97722ccc2389a9f9b7cf4d9411b92db98
Cr-Commit-Position: refs/heads/master@{#13718}

Powered by Google App Engine
This is Rietveld 408576698