Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2228923002: Add Android bots to MB. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add Android bots to MB. BUG=589510 NOTRY=True Committed: https://crrev.com/89b0ca878c6b3ac728a3db4afb707ed5b1cd530b Cr-Commit-Position: refs/heads/master@{#13696}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add android_compile_x64_dbg to trybots. #

Patch Set 3 : Rebased CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -4 lines) Patch
M webrtc/build/mb_config.pyl View 1 2 6 chunks +133 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-09 13:58:09 UTC) #4
kjellander_webrtc
Nice work. I was only able to spot one thing. https://codereview.webrtc.org/2228923002/diff/20001/webrtc/build/mb_config.pyl File webrtc/build/mb_config.pyl (right): https://codereview.webrtc.org/2228923002/diff/20001/webrtc/build/mb_config.pyl#newcode102 ...
4 years, 4 months ago (2016-08-09 14:51:42 UTC) #5
ehmaldonado_webrtc
On 2016/08/09 14:51:42, kjellander_webrtc wrote: > Nice work. I was only able to spot one ...
4 years, 4 months ago (2016-08-09 14:58:32 UTC) #6
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-09 15:02:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2228923002/80001
4 years, 4 months ago (2016-08-09 15:08:11 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 4 months ago (2016-08-09 15:15:08 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:15:17 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89b0ca878c6b3ac728a3db4afb707ed5b1cd530b
Cr-Commit-Position: refs/heads/master@{#13696}

Powered by Google App Engine
This is Rietveld 408576698