Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2235893003: Remove the old AndroidVideoCapturer stack code. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the old AndroidVideoCapturer stack code. This code is no longer needed. Apps should be using the new API introduced here: https://codereview.webrtc.org/2127893002/ Committed: https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d Cr-Commit-Position: refs/heads/master@{#13950}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -725 lines) Patch
M webrtc/api/BUILD.gn View 1 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturer.java View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/api/android/jni/androidvideocapturer_jni.h View 1 chunk +0 lines, -101 lines 0 comments Download
D webrtc/api/android/jni/androidvideocapturer_jni.cc View 1 chunk +0 lines, -349 lines 0 comments Download
M webrtc/api/android/jni/classreferenceholder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 3 chunks +1 line, -26 lines 0 comments Download
D webrtc/api/androidvideocapturer.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/api/androidvideocapturer.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
sakal
PTAL
4 years, 3 months ago (2016-08-26 07:50:25 UTC) #2
magjed_webrtc
Nice to get rid of this. lgtm
4 years, 3 months ago (2016-08-26 08:07:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235893003/20001
4 years, 3 months ago (2016-08-26 08:07:41 UTC) #7
sakal
Alex, PTAL.
4 years, 3 months ago (2016-08-26 08:08:16 UTC) #10
AlexG
lgtm
4 years, 3 months ago (2016-08-26 20:53:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235893003/20001
4 years, 3 months ago (2016-08-29 07:19:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) android_gn_rel on ...
4 years, 3 months ago (2016-08-29 07:19:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235893003/20001
4 years, 3 months ago (2016-08-29 07:27:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) android_gn_rel on ...
4 years, 3 months ago (2016-08-29 07:27:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235893003/20001
4 years, 3 months ago (2016-08-29 07:41:08 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16044)
4 years, 3 months ago (2016-08-29 07:50:19 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235893003/20001
4 years, 3 months ago (2016-08-29 08:43:27 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-29 09:20:26 UTC) #27
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1b365a8db070f9cdcbf35ec871f758dcd909e51d Cr-Commit-Position: refs/heads/master@{#13950}
4 years, 3 months ago (2016-08-29 09:20:33 UTC) #29
sakal
4 years, 3 months ago (2016-08-29 14:31:07 UTC) #30
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2291583002/ by sakal@webrtc.org.

The reason for reverting is: Breaks downstream..

Powered by Google App Engine
This is Rietveld 408576698