Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Committed: https://crrev.com/70f866c647fde769e9685e20596b568cc7e27c15
Cr-Original-Commit-Position: refs/heads/master@{#13752}
Cr-Commit-Position: refs/heads/master@{#13772}

[aleloi, 2016-08-11 08:09:39]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-11 08:09:40]

Mini-change that fixes dependencies to new mixer and adds it to |check_targets|
in .gn. Could you take a look?

https://codereview.webrtc.org/2234293002/diff/1/webrtc/modules/audio_mixer/BU...
File webrtc/modules/audio_mixer/BUILD.gn (right):

https://codereview.webrtc.org/2234293002/diff/1/webrtc/modules/audio_mixer/BU...
webrtc/modules/audio_mixer/BUILD.gn:80:
"../../system_wrappers:system_wrappers_default",
Those were missing dependencies.

https://codereview.webrtc.org/2234293002/diff/1/webrtc/modules/audio_mixer/ne...
File webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h (right):

https://codereview.webrtc.org/2234293002/diff/1/webrtc/modules/audio_mixer/ne...
webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h:66:
~NewAudioConferenceMixerImpl() override;
Added explicit destructor because of chromium-style error.

[kjellander_webrtc, 2016-08-15 13:36:55]

lgtm

I think you're safe with NOTRY=True if you just run a few more trybots.

[aleloi, 2016-08-15 13:57:40]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True
==========

[aleloi, 2016-08-15 14:16:45]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-15 14:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 14:24:09]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-15 14:24:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-15 14:24:20]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

[commit-bot: I haz the power, 2016-08-15 14:24:22]

Patchset 1 (id:??) landed as
https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}

[olka_webrtc, 2016-08-15 14:36:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2241243002/ by olka@webrtc.org.

The reason for reverting is: Breaks Chromium FYI builds, for example
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

[aleloi, 2016-08-15 14:42:50]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

[aleloi, 2016-08-16 08:50:48]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-08-16 09:00:45]

Patchset #2 (id:40001) has been deleted

[aleloi, 2016-08-16 09:08:23]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-08-16 09:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2234293002/#ps60001 (title:
"Depending on a system_wrappers implementation in audio_mixer broke chrome.")

[commit-bot: I haz the power, 2016-08-16 09:08:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-16 09:15:52]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

[commit-bot: I haz the power, 2016-08-16 09:15:53]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-16 09:16:02]

Description was changed from

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Cr-Commit-Position: refs/heads/master@{#13752}
==========

to

==========
Added new mixer to |check_targets| in .gn and fixed include/depend errors.

Also fixed one small chromium-style error in the new mixer.

NOTRY=True

Committed: https://crrev.com/d700bef583d29ba2834ae57b3af7e8d3b8306cb9
Committed: https://crrev.com/70f866c647fde769e9685e20596b568cc7e27c15
Cr-Original-Commit-Position: refs/heads/master@{#13752}
Cr-Commit-Position: refs/heads/master@{#13772}
==========

[commit-bot: I haz the power, 2016-08-16 09:16:03]

Patchset 2 (id:??) landed as
https://crrev.com/70f866c647fde769e9685e20596b568cc7e27c15
Cr-Commit-Position: refs/heads/master@{#13772}