Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: .gn

Issue 2234293002: Added new mixer to |check_targets| in .gn and fixed include/depend errors. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@mixer_dir_structure_comments
Patch Set: Depending on a system_wrappers implementation in audio_mixer broke chrome. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # The location of the build configuration file. 9 # The location of the build configuration file.
10 buildconfig = "//build/config/BUILDCONFIG.gn" 10 buildconfig = "//build/config/BUILDCONFIG.gn"
11 11
12 # The secondary source root is a parallel directory tree where 12 # The secondary source root is a parallel directory tree where
13 # GN build files are placed when they can not be placed directly 13 # GN build files are placed when they can not be placed directly
14 # in the source tree, e.g. for third party source trees. 14 # in the source tree, e.g. for third party source trees.
15 secondary_source = "//build/secondary/" 15 secondary_source = "//build/secondary/"
16 16
17 # These are the targets to check headers for by default. The files in targets 17 # These are the targets to check headers for by default. The files in targets
18 # matching these patterns (see "gn help label_pattern" for format) will have 18 # matching these patterns (see "gn help label_pattern" for format) will have
19 # their includes checked for proper dependencies when you run either 19 # their includes checked for proper dependencies when you run either
20 # "gn check" or "gn gen --check". 20 # "gn check" or "gn gen --check".
21 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e. 21 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e.
22 check_targets = [ 22 check_targets = [
23 "//webrtc/voice_engine:level_indicator", 23 "//webrtc/voice_engine:level_indicator",
24 "//webrtc/modules/audio_coding:isac_fix_test", 24 "//webrtc/modules/audio_coding:isac_fix_test",
25 "//webrtc/modules/audio_mixer:audio_conference_mixer",
25 ] 26 ]
26 27
27 # These are the list of GN files that run exec_script. This whitelist exists 28 # These are the list of GN files that run exec_script. This whitelist exists
28 # to force additional review for new uses of exec_script, which is strongly 29 # to force additional review for new uses of exec_script, which is strongly
29 # discouraged except for gypi_to_gn calls. 30 # discouraged except for gypi_to_gn calls.
30 exec_script_whitelist = [ 31 exec_script_whitelist = [
31 "//build/config/BUILD.gn", 32 "//build/config/BUILD.gn",
32 "//build/config/android/BUILD.gn", 33 "//build/config/android/BUILD.gn",
33 "//build/config/android/config.gni", 34 "//build/config/android/config.gni",
34 "//build/config/android/internal_rules.gni", 35 "//build/config/android/internal_rules.gni",
(...skipping 12 matching lines...) Expand all
47 "//build/toolchain/concurrent_links.gni", 48 "//build/toolchain/concurrent_links.gni",
48 "//build/toolchain/gcc_toolchain.gni", 49 "//build/toolchain/gcc_toolchain.gni",
49 "//build/toolchain/mac/BUILD.gn", 50 "//build/toolchain/mac/BUILD.gn",
50 "//build/toolchain/win/BUILD.gn", 51 "//build/toolchain/win/BUILD.gn",
51 "//third_party/boringssl/BUILD.gn", 52 "//third_party/boringssl/BUILD.gn",
52 "//third_party/openh264/BUILD.gn", 53 "//third_party/openh264/BUILD.gn",
53 "//third_party/opus/BUILD.gn", 54 "//third_party/opus/BUILD.gn",
54 "//webrtc/modules/video_render/BUILD.gn", 55 "//webrtc/modules/video_render/BUILD.gn",
55 "//webrtc/modules/video_render/BUILD.gn", 56 "//webrtc/modules/video_render/BUILD.gn",
56 ] 57 ]
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698