GN: Update tests to have the correct shard timeout value on Android.

GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True

Committed: https://crrev.com/714dd4e532752fcf46efea3370dcefbb4b9575d6
Cr-Commit-Position: refs/heads/master@{#13741}

[sakal, 2016-08-11 13:15:19]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 13:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-08-11 13:41:41]

sakal@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[sakal, 2016-08-11 13:42:16]

PTAL

I verified that all tests are started using the correct shard timeout parameter.

[commit-bot: I haz the power, 2016-08-11 15:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:16:00]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2016-08-15 06:55:08]

lgtm with comments adressed

Please use NOTRY=True since this is not really affecting any bots except GN ones
yet (run just a few GN trybots to ensure the GN config is not broken)

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode607
webrtc/BUILD.gn:607: shard_timeout = 900
Please put this at line 581 instead.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode674
webrtc/BUILD.gn:674: shard_timeout = 900
Hmm, this test was added in https://codereview.webrtc.org/2064523002 but it
doesn't seem to have the necessary stuff to run on Android in its GN version.
Could you also 
1) add:
deps += [ "//testing/android/native_test:native_test_native_code" ]
2) add data entries for the two resource files listed in
https://cs.chromium.org/chromium/src/third_party/webrtc/video_engine_tests.is...
?

It's OK to do this work in a separate CL though, since it widens the scope of
this one. Also feel free to delegate to somebody else with a bug.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode743
webrtc/BUILD.gn:743: shard_timeout = 2700
Please move to line 736.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode786
webrtc/BUILD.gn:786: shard_timeout = 900
Please move to line 772.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/BUILD.gn#newco...
webrtc/modules/BUILD.gn:111: shard_timeout = 900
Move to line 87.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1041: shard_timeout = 900
--> line 1032.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1136: shard_timeout = 900
--> line 1124.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/voice_engine/BUILD.gn
File webrtc/voice_engine/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/voice_engine/BUILD.gn#...
webrtc/voice_engine/BUILD.gn:177: shard_timeout = 900
--> line 146.

[sakal, 2016-08-15 07:44:40]

Description was changed from

==========
GN: Update tests to have the correct shard timeout value on Android.
==========

to

==========
GN: Update tests to have the correct shard timeout value on Android.

NOTRY=True
==========

[sakal, 2016-08-15 07:44:55]

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode607
webrtc/BUILD.gn:607: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> Please put this at line 581 instead.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode674
webrtc/BUILD.gn:674: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> Hmm, this test was added in https://codereview.webrtc.org/2064523002 but it
> doesn't seem to have the necessary stuff to run on Android in its GN version.
> Could you also 
> 1) add:
> deps += [ "//testing/android/native_test:native_test_native_code" ]
> 2) add data entries for the two resource files listed in
>
https://cs.chromium.org/chromium/src/third_party/webrtc/video_engine_tests.is...
> ?
> 
> It's OK to do this work in a separate CL though, since it widens the scope of
> this one. Also feel free to delegate to somebody else with a bug.

Acknowledged.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode743
webrtc/BUILD.gn:743: shard_timeout = 2700
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> Please move to line 736.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/BUILD.gn#newcode786
webrtc/BUILD.gn:786: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> Please move to line 772.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/BUILD.gn#newco...
webrtc/modules/BUILD.gn:111: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> Move to line 87.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1041: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> --> line 1032.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1136: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> --> line 1124.

Done.

https://codereview.webrtc.org/2231413002/diff/1/webrtc/voice_engine/BUILD.gn
File webrtc/voice_engine/BUILD.gn (right):

https://codereview.webrtc.org/2231413002/diff/1/webrtc/voice_engine/BUILD.gn#...
webrtc/voice_engine/BUILD.gn:177: shard_timeout = 900
On 2016/08/15 06:55:08, kjellander_webrtc wrote:
> --> line 146.

Done.

[sakal, 2016-08-15 07:45:02]

The CQ bit was checked by sakal@webrtc.org

[sakal, 2016-08-15 07:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2231413002/#ps20001 (title:
"Fixes according to comments.")

[commit-bot: I haz the power, 2016-08-15 07:45:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 08:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 08:00:36]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7406)

[kjellander_webrtc, 2016-08-15 08:08:00]

On 2016/08/15 08:00:36, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7406)

It seems I've missed to establish myself as owner in webrtc/modules:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    webrtc/modules/BUILD.gn

[kjellander_webrtc, 2016-08-15 08:08:35]

On 2016/08/15 08:08:00, kjellander_webrtc wrote:
> On 2016/08/15 08:00:36, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   presubmit on master.tryserver.webrtc (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7406)
> 
> It seems I've missed to establish myself as owner in webrtc/modules:
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     webrtc/modules/BUILD.gn

for this, it's fine to just TBR someone in there or the root OWNERS flle.

[sakal, 2016-08-15 08:50:08]

Description was changed from

==========
GN: Update tests to have the correct shard timeout value on Android.

NOTRY=True
==========

to

==========
GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True
==========

[sakal, 2016-08-15 08:50:09]

sakal@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[sakal, 2016-08-15 08:50:19]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-08-15 08:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 09:29:19]

Description was changed from

==========
GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True
==========

to

==========
GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-15 09:29:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 09:29:25]

Description was changed from

==========
GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True
==========

to

==========
GN: Update tests to have the correct shard timeout value on Android.

TBR=mflodman@webrtc.org
NOTRY=True

Committed: https://crrev.com/714dd4e532752fcf46efea3370dcefbb4b9575d6
Cr-Commit-Position: refs/heads/master@{#13741}
==========

[commit-bot: I haz the power, 2016-08-15 09:29:26]

Patchset 2 (id:??) landed as
https://crrev.com/714dd4e532752fcf46efea3370dcefbb4b9575d6
Cr-Commit-Position: refs/heads/master@{#13741}