GN: Add video_engine_tests

GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/0208322ee36b1f6f159194b9b451d2171c1a8ce4
Cr-Commit-Position: refs/heads/master@{#13127}

[pbos-webrtc, 2016-06-12 22:33:11]

PTAL, and let me know which bug number to use (or fill it in yourself)

[kjellander_webrtc, 2016-06-13 05:15:24]

Description was changed from

==========
Add video_engine_tests to GN configuration.

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=
R=kjellander@webrtc.org
==========

to

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
==========

[kjellander_webrtc, 2016-06-13 05:15:46]

Thanks for the contribution. I changed title and BUG= field.

https://codereview.webrtc.org/2064523002/diff/1/webrtc/audio/BUILD.gn
File webrtc/audio/BUILD.gn (right):

https://codereview.webrtc.org/2064523002/diff/1/webrtc/audio/BUILD.gn#newcode55
webrtc/audio/BUILD.gn:55: }
For the compile error, add
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

https://codereview.webrtc.org/2064523002/diff/1/webrtc/call/BUILD.gn
File webrtc/call/BUILD.gn (right):

https://codereview.webrtc.org/2064523002/diff/1/webrtc/call/BUILD.gn#newcode41
webrtc/call/BUILD.gn:41: testonly = true
Either keep the old name "video_engine_tests" for now or land another CL
(synchronized with me) to rename the GYP test target first.

https://codereview.webrtc.org/2064523002/diff/1/webrtc/video/BUILD.gn
File webrtc/video/BUILD.gn (right):

https://codereview.webrtc.org/2064523002/diff/1/webrtc/video/BUILD.gn#newcode93
webrtc/video/BUILD.gn:93: "payload_router_unittest.cc",
Trybots says you need:
if (is_win) {
  cflags = [ "/wd4373" ]  # virtual override w/different const/volatile
signature.
}

[pbos-webrtc, 2016-06-13 09:50:50]

fix compile issues

[pbos-webrtc, 2016-06-13 10:03:48]

audio_receive_stream_unittest compile

[pbos-webrtc, 2016-06-13 10:16:07]

PTAL, I fixed the issues instead of introducing suppressions.

[kjellander_webrtc, 2016-06-13 11:37:19]

Great that you fixed the warnings instead.

https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:190: "testsupport/metrics/video_metrics.cc",
These are located in a separate 'metrics' target to avoid a circular dependency
for GYP. Doesn't it become the same problem with GN? Can you try to run gn
check?

[pbos-webrtc, 2016-06-13 20:27:13]

On 2016/06/13 11:37:19, kjellander_webrtc wrote:
> Great that you fixed the warnings instead.
> 
> https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn#newc...
> webrtc/test/BUILD.gn:190: "testsupport/metrics/video_metrics.cc",
> These are located in a separate 'metrics' target to avoid a circular
dependency
> for GYP. Doesn't it become the same problem with GN? Can you try to run gn
> check?

pbos@deimos:~/webrtc/src (video_engine_gn_tests)$ gn gen out/Default/ --check
Done. Wrote 385 targets from 95 files in 225ms
pbos@deimos:~/webrtc/src (video_engine_gn_tests)$ gn check out/Default
0 targets out of 234 checked based on the check_targets defined in ".gn".
Header dependency check OK

Hope either of those cover it, right?

[kjellander_webrtc, 2016-06-14 10:43:48]

On 2016/06/13 20:27:13, pbos-webrtc wrote:
> On 2016/06/13 11:37:19, kjellander_webrtc wrote:
> > Great that you fixed the warnings instead.
> > 
> > https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn
> > File webrtc/test/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2064523002/diff/40001/webrtc/test/BUILD.gn#newc...
> > webrtc/test/BUILD.gn:190: "testsupport/metrics/video_metrics.cc",
> > These are located in a separate 'metrics' target to avoid a circular
> dependency
> > for GYP. Doesn't it become the same problem with GN? Can you try to run gn
> > check?
> 
> pbos@deimos:~/webrtc/src (video_engine_gn_tests)$ gn gen out/Default/ --check
> Done. Wrote 385 targets from 95 files in 225ms
> pbos@deimos:~/webrtc/src (video_engine_gn_tests)$ gn check out/Default
> 0 targets out of 234 checked based on the check_targets defined in ".gn".
> Header dependency check OK
> 
> Hope either of those cover it, right?

I can't tell for sure, so we'll have to deal with that later in any case.

lgtm

[pbos-webrtc, 2016-06-14 10:52:13]

Description was changed from

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
==========

to

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org
==========

[pbos-webrtc, 2016-06-14 10:52:44]

pbos@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[pbos-webrtc, 2016-06-14 10:52:45]

TBR=mflodman for rubberstamp for the simple changes in:

    webrtc/audio/audio_receive_stream_unittest.cc
    webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
    webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
    webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
    webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
    webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc
    webrtc/modules/rtp_rtcp/test/testAPI/test_api.h
    webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc

[pbos-webrtc, 2016-06-14 10:53:13]

Description was changed from

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org
==========

to

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/0208322ee36b1f6f159194b9b...
==========

[commit-bot: I haz the power, 2016-06-14 10:53:14]

Description was changed from

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/0208322ee36b1f6f159194b9b...
==========

to

==========
GN: Add video_engine_tests

Adds separate source_sets for the video_engine_tests subtargets inside
audio, call and video and merges them together into video_engine_tests.

BUG=webrtc:5949
R=kjellander@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/0208322ee36b1f6f159194b9b451d2171c1a8ce4
Cr-Commit-Position: refs/heads/master@{#13127}
==========

[pbos-webrtc, 2016-06-14 10:53:15]

Committed patchset #3 (id:40001) manually as
0208322ee36b1f6f159194b9b451d2171c1a8ce4 (presubmit successful).

[commit-bot: I haz the power, 2016-06-14 10:53:15]

Patchset 3 (id:??) landed as
https://crrev.com/0208322ee36b1f6f159194b9b451d2171c1a8ce4
Cr-Commit-Position: refs/heads/master@{#13127}