Migrated GN target :neteq_ilbc_quality_test

webrtc/modules/audio_coding/BUILD.gn

Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index dcd4222dbfa13da7aa1d7093ee27f355dd1a9683..c9fec6c89ac09f2661a5d3fe787015f74e39d840 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -1167,6 +1167,7 @@ if (rtc_include_tests) {
       "neteq/tools/audio_checksum.h",
       "neteq/tools/audio_loop.cc",
       "neteq/tools/audio_loop.h",
+      "neteq/tools/audio_sink.cc",

[aleloi, 2016/08/10 10:14:01]

The chromium-style error was that a virtual method was defined inline. I moved
it out to a new file, audio_sink.cc

       "neteq/tools/audio_sink.h",
       "neteq/tools/constant_pcm_packet_source.cc",
       "neteq/tools/constant_pcm_packet_source.h",
@@ -1388,16 +1389,30 @@ if (rtc_include_tests) {
     deps = [
       ":neteq",
       ":neteq_test_support",
+      ":neteq_unittest_tools",

[aleloi, 2016/08/10 10:14:01]

Since we import a header from unittest_tools, we should depend on it directly.
It's a private dependency from neteq_test_support, and gn doesn't complain, but
'gn path' says "No non-data paths found between these two targets". When I
didn't add the target explicitly, that is.

       ":webrtc_opus",
       "../../test:test_support_main",
       "//testing/gtest",
       "//third_party/gflags",
     ]
+  }
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugins
-      # (bugs.webrtc.org/163).
-      configs -= [ "//build/config/clang:find_bad_constructs" ]
-    }

[aleloi, 2016/08/10 10:14:01]

This is from the 'opus' target. I find the diff confusing.

+  executable("neteq_ilbc_quality_test") {
+    testonly = true
+
+    sources = [
+      "neteq/test/neteq_ilbc_quality_test.cc",
+    ]
+
+    deps = [
+      ":ilbc",
+      ":neteq",
+      ":neteq_test_support",
+      ":neteq_unittest_tools",
+      "../../system_wrappers:system_wrappers_default",
+      "../../test:test_support_main",
+      "//testing/gtest",
+      "//third_party/gflags",
+    ]
   }
 }