Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: webrtc/base/win32socketserver_unittest.cc

Issue 2218853002: Reland Enable socketservers unittests on windows. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable failing tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/socket_unittest.cc ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/win32socketserver_unittest.cc
diff --git a/webrtc/base/win32socketserver_unittest.cc b/webrtc/base/win32socketserver_unittest.cc
index daf9e70d1fca21374ff546a6aefa7753c950b87c..f40fd5f530ae8293f51e4c9c16e44ebc36669ea2 100644
--- a/webrtc/base/win32socketserver_unittest.cc
+++ b/webrtc/base/win32socketserver_unittest.cc
@@ -30,8 +30,8 @@ TEST(Win32SocketServerTest, TestPump) {
server.Pump();
MSG msg;
EXPECT_EQ(TRUE, PeekMessage(&msg, NULL, WM_USER, 0, PM_REMOVE));
- EXPECT_EQ(WM_USER, msg.message);
- EXPECT_EQ(999, msg.wParam);
+ EXPECT_EQ(static_cast<UINT>(WM_USER), msg.message);
+ EXPECT_EQ(999u, msg.wParam);
}
// Test that Win32Socket passes all the generic Socket tests.
@@ -146,11 +146,15 @@ TEST_F(Win32SocketTest, TestUdpIPv6) {
SocketTest::TestUdpIPv6();
}
-TEST_F(Win32SocketTest, TestGetSetOptionsIPv4) {
+// Breaks win_x64_dbg bot.
+// https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
+TEST_F(Win32SocketTest, DISABLED_TestGetSetOptionsIPv4) {
SocketTest::TestGetSetOptionsIPv4();
}
-TEST_F(Win32SocketTest, TestGetSetOptionsIPv6) {
+// Breaks win_x64_dbg bot.
+// https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
+TEST_F(Win32SocketTest, DISABLED_TestGetSetOptionsIPv6) {
SocketTest::TestGetSetOptionsIPv6();
}
« no previous file with comments | « webrtc/base/socket_unittest.cc ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698