Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: webrtc/base/win32socketserver_unittest.cc

Issue 2218853002: Reland Enable socketservers unittests on windows. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable failing tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/socket_unittest.cc ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2009 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2009 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/base/gunit.h" 10 #include "webrtc/base/gunit.h"
(...skipping 12 matching lines...) Expand all
23 } 23 }
24 24
25 // Test that Win32Socket::Pump does not touch general Windows messages. 25 // Test that Win32Socket::Pump does not touch general Windows messages.
26 TEST(Win32SocketServerTest, TestPump) { 26 TEST(Win32SocketServerTest, TestPump) {
27 Win32SocketServer server(NULL); 27 Win32SocketServer server(NULL);
28 SocketServerScope scope(&server); 28 SocketServerScope scope(&server);
29 EXPECT_EQ(TRUE, PostMessage(NULL, WM_USER, 999, 0)); 29 EXPECT_EQ(TRUE, PostMessage(NULL, WM_USER, 999, 0));
30 server.Pump(); 30 server.Pump();
31 MSG msg; 31 MSG msg;
32 EXPECT_EQ(TRUE, PeekMessage(&msg, NULL, WM_USER, 0, PM_REMOVE)); 32 EXPECT_EQ(TRUE, PeekMessage(&msg, NULL, WM_USER, 0, PM_REMOVE));
33 EXPECT_EQ(WM_USER, msg.message); 33 EXPECT_EQ(static_cast<UINT>(WM_USER), msg.message);
34 EXPECT_EQ(999, msg.wParam); 34 EXPECT_EQ(999u, msg.wParam);
35 } 35 }
36 36
37 // Test that Win32Socket passes all the generic Socket tests. 37 // Test that Win32Socket passes all the generic Socket tests.
38 class Win32SocketTest : public SocketTest { 38 class Win32SocketTest : public SocketTest {
39 protected: 39 protected:
40 Win32SocketTest() : server_(NULL), scope_(&server_) {} 40 Win32SocketTest() : server_(NULL), scope_(&server_) {}
41 Win32SocketServer server_; 41 Win32SocketServer server_;
42 SocketServerScope scope_; 42 SocketServerScope scope_;
43 }; 43 };
44 44
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 } 139 }
140 140
141 TEST_F(Win32SocketTest, TestUdpIPv4) { 141 TEST_F(Win32SocketTest, TestUdpIPv4) {
142 SocketTest::TestUdpIPv4(); 142 SocketTest::TestUdpIPv4();
143 } 143 }
144 144
145 TEST_F(Win32SocketTest, TestUdpIPv6) { 145 TEST_F(Win32SocketTest, TestUdpIPv6) {
146 SocketTest::TestUdpIPv6(); 146 SocketTest::TestUdpIPv6();
147 } 147 }
148 148
149 TEST_F(Win32SocketTest, TestGetSetOptionsIPv4) { 149 // Breaks win_x64_dbg bot.
150 // https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
151 TEST_F(Win32SocketTest, DISABLED_TestGetSetOptionsIPv4) {
150 SocketTest::TestGetSetOptionsIPv4(); 152 SocketTest::TestGetSetOptionsIPv4();
151 } 153 }
152 154
153 TEST_F(Win32SocketTest, TestGetSetOptionsIPv6) { 155 // Breaks win_x64_dbg bot.
156 // https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
157 TEST_F(Win32SocketTest, DISABLED_TestGetSetOptionsIPv6) {
154 SocketTest::TestGetSetOptionsIPv6(); 158 SocketTest::TestGetSetOptionsIPv6();
155 } 159 }
156 160
157 } // namespace rtc 161 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/socket_unittest.cc ('k') | webrtc/webrtc_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698