Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2218853002: Reland Enable socketservers unittests on windows. (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, ehmaldonado_webrtc, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Enable socketservers unittests on windows. Original CL: https://codereview.webrtc.org/2199193004/ Revert CL: https://codereview.webrtc.org/2209333002/ NOTRY=true BUG=webrtc:6167, webrtc:6178 Committed: https://crrev.com/b7b9dca4e43fba58bc1ec0fedbd0f92882af4c3a Cr-Commit-Position: refs/heads/master@{#13654}

Patch Set 1 : Original CL #

Patch Set 2 : Disable failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -36 lines) Patch
M webrtc/BUILD.gn View 2 chunks +4 lines, -11 lines 0 comments Download
M webrtc/base/physicalsocketserver_unittest.cc View 2 chunks +21 lines, -3 lines 0 comments Download
M webrtc/base/socket_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/socket_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/base/win32socketserver_unittest.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
danilchap
4 years, 4 months ago (2016-08-05 09:18:28 UTC) #4
tommi
lgtm
4 years, 4 months ago (2016-08-05 12:51:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2218853002/20001
4 years, 4 months ago (2016-08-05 12:54:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 12:55:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:55:56 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7b9dca4e43fba58bc1ec0fedbd0f92882af4c3a
Cr-Commit-Position: refs/heads/master@{#13654}

Powered by Google App Engine
This is Rietveld 408576698